1268915 - Mixed content tests are broken on windows because they read the files wrong

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Boris Zbarsky [:bzbarsky]]

They read the image/video/etc files as text, which causes them to mess up the bytes, which causes the files to not load correctly in browser, which makes the browser parts of the test think they're always blocked.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix mixed-content web platform tests to not screw up their bytes on Windows

I still have a try run outstanding, so it's possible some of the ini files might still change, but I think I got all the relevant ones.  If they do change, I'll post an interdiff

Comment 2

[Ryan VanderMeulen [:RyanVM]]

How easily could we audit the rest of w-p-t for other similar issues?

Comment 3

[Boris Zbarsky [:bzbarsky]]

It's pretty easy to get a list of open() calls in Python files in there:

  mozilla% find testing/web-platform/tests/ -name "*.py" | xargs fgrep "open(" | wc -l
     251

But that's not really that helpful...  What would be more useful, perhaps, would be looking at ini files to see things that are disabled on a per-platform basis.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Sounds like a good project for those who maintain these tests :P. Probably should be incorporated into whatever upstream review process there is for new tests too.

Also, looks like WinXP still isn't happy :(. I wonder what version of Python we have installed on those machines...

Comment 5

[Boris Zbarsky [:bzbarsky]]

The WinXP unhappiness is all video-tag.  I expect that has more to do with our media stack on WinXP than python versions....

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be7df3a3e5b6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be7df3a3e5b6

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fcf65f9b9fad