Mixed content tests are broken on windows because they read the files wrong

RESOLVED FIXED in Firefox 48

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

(Depends on 1 bug)

unspecified
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed)

Details

Attachments

(1 attachment)

They read the image/video/etc files as text, which causes them to mess up the bytes, which causes the files to not load correctly in browser, which makes the browser parts of the test think they're always blocked.
I still have a try run outstanding, so it's possible some of the ini files might still change, but I think I got all the relevant ones.  If they do change, I'll post an interdiff
Attachment #8747127 - Flags: review?(james)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8747127 - Flags: review?(james) → review+
How easily could we audit the rest of w-p-t for other similar issues?
It's pretty easy to get a list of open() calls in Python files in there:

  mozilla% find testing/web-platform/tests/ -name "*.py" | xargs fgrep "open(" | wc -l
     251

But that's not really that helpful...  What would be more useful, perhaps, would be looking at ini files to see things that are disabled on a per-platform basis.
Sounds like a good project for those who maintain these tests :P. Probably should be incorporated into whatever upstream review process there is for new tests too.

Also, looks like WinXP still isn't happy :(. I wonder what version of Python we have installed on those machines...
The WinXP unhappiness is all video-tag.  I expect that has more to do with our media stack on WinXP than python versions....

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/be7df3a3e5b6
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Depends on: 1269716
You need to log in before you can comment on or make changes to this bug.