Closed
Bug 1268915
Opened 8 years ago
Closed 8 years ago
Mixed content tests are broken on windows because they read the files wrong
Categories
(Testing :: web-platform-tests, defect)
Testing
web-platform-tests
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
mozilla49
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
75.03 KB,
patch
|
jgraham
:
review+
|
Details | Diff | Splinter Review |
They read the image/video/etc files as text, which causes them to mess up the bytes, which causes the files to not load correctly in browser, which makes the browser parts of the test think they're always blocked.
Assignee | ||
Comment 1•8 years ago
|
||
I still have a try run outstanding, so it's possible some of the ini files might still change, but I think I got all the relevant ones. If they do change, I'll post an interdiff
Attachment #8747127 -
Flags: review?(james)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Updated•8 years ago
|
Attachment #8747127 -
Flags: review?(james) → review+
Comment 2•8 years ago
|
||
How easily could we audit the rest of w-p-t for other similar issues?
Assignee | ||
Comment 3•8 years ago
|
||
It's pretty easy to get a list of open() calls in Python files in there: mozilla% find testing/web-platform/tests/ -name "*.py" | xargs fgrep "open(" | wc -l 251 But that's not really that helpful... What would be more useful, perhaps, would be looking at ini files to see things that are disabled on a per-platform basis.
Comment 4•8 years ago
|
||
Sounds like a good project for those who maintain these tests :P. Probably should be incorporated into whatever upstream review process there is for new tests too. Also, looks like WinXP still isn't happy :(. I wonder what version of Python we have installed on those machines...
Assignee | ||
Comment 5•8 years ago
|
||
The WinXP unhappiness is all video-tag. I expect that has more to do with our media stack on WinXP than python versions....
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/be7df3a3e5b6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/fcf65f9b9fad
status-firefox48:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•