Closed
Bug 1269068
Opened 8 years ago
Closed 8 years ago
[APZ] Perma-checkerboarding when page-scrolling with wheel during loading
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
VERIFIED
FIXED
mozilla49
People
(Reporter: arni2033, Assigned: kats)
References
Details
(Keywords: regression, Whiteboard: [gfx-noted])
Attachments
(2 files)
736.35 KB,
video/webm
|
Details | |
58 bytes,
text/x-review-board-request
|
botond
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
>>> My Info: Win7_64, Nightly 49, 32bit, ID 20160429030215 STR: 0. Set mouse option "when I rotate mouse wheel" in your OS to "scroll by 1 page" 1. Open https://hi-tech.mail.ru/news/rissian-brest-300-nuclear-reactor/ 2. Press PageDown to scroll the page down, then press Ctrl+Shift+R to reload 3. The same instant you see scrollbar moving, rotate mouse wheel down once AR: When web page finishes loading, it's still partially white (I can provide another screencast). ER: Web page should be displayed in a normal way. Note: I encountered this issue many times, and now I finally decided to file it. This is regression from bug 1247677. Regression range (seems strange, thus NI): > https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9bce2f3c14e8920051de0c6f71a1e6a728949cba&tochange=558b65cbe70daed21cf648650cf29658a5b13855
Flags: needinfo?(bugmail.mozilla)
Comment hidden (spam) |
Assignee | ||
Comment 2•8 years ago
|
||
I can reproduce this. I'm not entirely sure why the regression range points to bug 1247677, but it seems plausible since it added support for some mousewheel page-scrolling prefs. I can look into this bug.
Assignee: nobody → bugmail.mozilla
Flags: needinfo?(bugmail.mozilla)
OS: Unspecified → Windows
Whiteboard: [gfx-noted]
Version: unspecified → 49 Branch
Assignee | ||
Updated•8 years ago
|
Summary: [APZ] Part of the page stays partially white when I scroll it during loading → [APZ] Perma-checkerboarding when page-scrolling with wheel during loading
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50053/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50053/
Attachment #8747891 -
Flags: review?(botond)
Updated•8 years ago
|
Attachment #8747891 -
Flags: review?(botond) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8747891 [details] MozReview Request: Bug 1269068 - Zero out the axis velocity once the wheel scroll animation is terminating. r?botond https://reviewboard.mozilla.org/r/50053/#review46819
Comment 5•8 years ago
|
||
It might be nice to have the connection between not zeroing out the velocity, and perma-checkerboarding, explained in a comment on this bug.
Assignee | ||
Comment 6•8 years ago
|
||
What I was seeing is that the velocity gets left at non-zero, and the velocity bias code in displayport prediction was shifting the displayport away from what the user was seeing. I presume it happens with line-scrolling as well, but page scrolling makes it more noticeable because of the higher velocities involved. Zeroing out the velocity at the end of the animation makes sure the displayport shifts back to center, and makes sense given that the animation is over.
Assignee | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/909af7c19ebb
Comment 8•8 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #6) Thanks!
Assignee | ||
Updated•8 years ago
|
status-firefox46:
--- → wontfix
status-firefox47:
--- → wontfix
status-firefox48:
--- → affected
status-firefox49:
--- → affected
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/909af7c19ebb
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Reporter | ||
Comment 10•8 years ago
|
||
Fixed on: Win7_64, Nightly 49, 32bit, ID 20160504043118
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8747891 [details] MozReview Request: Bug 1269068 - Zero out the axis velocity once the wheel scroll animation is terminating. r?botond Approval Request Comment [Feature/regressing bug #]: bug 1247677 [User impact if declined]: in some cases the user can end up with checkerboarding on the screen which doesn't go away until the user scrolls or does something to trigger a repaint [Describe test coverage new/current, TreeHerder]: tested locally [Risks and why]: very low risk, small patch [String/UUID change made/needed]: none
Attachment #8747891 -
Flags: approval-mozilla-aurora?
Comment 12•8 years ago
|
||
Comment on attachment 8747891 [details] MozReview Request: Bug 1269068 - Zero out the axis velocity once the wheel scroll animation is terminating. r?botond More APZ polish for aurora, verified on nightly already.
Attachment #8747891 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/0b5925bf7d52
You need to log in
before you can comment on or make changes to this bug.
Description
•