1269549 - Component watching prefix matches too much

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

I received a bug report from a user that is getting notifications for things they are not watching. I believe the prefix watching added in bug 720832 doesn't work.

This is part of the query used, and it should return nothing.

SELECT 
    user_id, profiles.login_name
FROM
    component_watch
        JOIN
    profiles ON userid = user_id
        INNER JOIN
    components ON components.product_id = component_watch.product_id
WHERE
    component_prefix IS NOT NULL
        AND (component_watch.product_id = 55
        OR component_watch.product_id = 55)
        AND components.name LIKE CONCAT(component_prefix, '%')

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1269549_1.patch

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8748018 [details] [diff] [review]
1269549_1.patch

Review of attachment 8748018 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 3

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   991b48e..6381dc7  master -> master