126981 - anchors in HTML mails broken

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Henrik Gemal]

This seems to have happend after the last checkin to the IMAP code (rfc2026).

If a HTML mail have internal anchors you get IMAP errors when pressing them:

One of the links in my HTMl mail is to an anchor called "#afsnit-2". The
complete link is:
imap://[e-mail]:143/fetch%3EUID%3E/INBOX/projects/test%3E4#afsnit-2

This produces:
1220[1f87cf8]: tarkin.int.tele.dk:S-INBOX/projects/test:SendData: 170 UID fetch
4#afsnit-1 (UID RFC822.SIZE BODY[])
1220[1f87cf8]: tarkin.int.tele.dk:S-INBOX/projects/test:CreateNewLineFromSocket:
170 BAD Protokolfejl: "Expected SPACE not found"

20020220

Comment 1

[Scott MacGregor]

anchors in html mail broke due to some string comparison changes in nsDocShell
on the 19th I think. 

We keep returning out of the scroll to anchor code early in this new clause:

    if (Substring(currentLeftStart, currentLeftEnd).Equals(sNewLeft)) {
        return NS_OK;           // URIs not the same
    }

if I bypass these lines we properly scroll to the anchor.

Comment 2

[Scott MacGregor]

I'm pretty sure the logic in this line is backwards. It's returning if the two
strings are equal and I think we want to be returning if they aren't equal.
patch coming up. 

Comment 3

[Scott MacGregor]

Attachment: the fix

Comment 4

[Alec Flett]

*** Bug 126646 has been marked as a duplicate of this bug. ***

Comment 5

[Alec Flett]

Comment on attachment 70783 [details] [diff] [review]
the fix

dammit you beat me to it! I had just fixed this when I got the bugmail!
sr=alecf of course

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 70783 [details] [diff] [review]
the fix

r=sspitzer

Comment 7

[Mike Shaver (:shaver emeritus)]

Comment on attachment 70783 [details] [diff] [review]
the fix

a=shaver for 0.9.9, etc.

Comment 8

[Scott MacGregor]

fix checked in. 

Comment 9

[R.K.Aa.]

i believe this fixed bug 127134 as well?

Comment 10

[Olav Vitters]

*** Bug 127163 has been marked as a duplicate of this bug. ***

Comment 11

[Boris Zbarsky [:bzbarsky]]

*** Bug 127134 has been marked as a duplicate of this bug. ***

Comment 12

[Boris Zbarsky [:bzbarsky]]

*** Bug 126900 has been marked as a duplicate of this bug. ***

Comment 13

[Olav Vitters]

*** Bug 127251 has been marked as a duplicate of this bug. ***

Comment 14

[Henrik Gemal]

not working in 2002022203
the fix should be in because I'm not longer getting IMAP error.

Comment 15

[Scott MacGregor]

anchors are now working again in the browser and in mailnews using 2002022203
bits. Let's track any different issues you are having in a new bug. 

Comment 16

[Henrik Gemal]

defined working in mail&news?

clicking on a IMAP link in a HTML mail like:
imap://[e-mail]:143/fetch%3EUID%3E/INBOX/projects/test%3E4#afsnit-2
does nothing...

Comment 17

[Scott MacGregor]

I define working as in: clicking on a link an html message which refers to an
anchor in that message. Same test case but in the browser too. In the browser
clicking on an anchor url did not scroll directly to the anchor. I took over
this bug to fix broken anchors for mail and the browser.

It was broken in yesterdays bits and this patch fixed it. We properly scroll to
that anchor again for both the mail and the browser case. 

Comment 18

[Henrik Gemal]

ok. will open new bug since it's not working in my HTML mail...

Comment 19

[Dimitrios]

*** Bug 127169 has been marked as a duplicate of this bug. ***