1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

There isn't a telemetry probe for clicking on the button to set up sync from the History panel.

Comment 1

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle

Review commit: https://reviewboard.mozilla.org/r/50519/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50519/

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8748757 [details]
MozReview Request: Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle

https://reviewboard.mozilla.org/r/50519/#review47301

LGTM. We seem to be using the (action, button, extra) pattern for other empty panels.

The only oddball is the private browsing hint, which is a clickable span [1], and we use (action, panel, extra) for it. I suppose it's OK, but I wouldn't care if that got changed to "button" too, for some consistency in empty panel actions.

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryPanel.java#405

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/123a7cac7ce9

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/123a7cac7ce9

Comment 5

[Chenxia Liu [:liuche]]

Comment on attachment 8748757 [details]
MozReview Request: Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle

Approval Request Comment
[Feature/regressing bug #]: Didn't have telemetry in bug 1220928
[User impact if declined]: No telemetry for click actions
[Describe test coverage new/current, TreeHerder]: Nightly
[Risks and why]: very low, add probe
[String/UUID change made/needed]: none

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8748757 [details]
MozReview Request: Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle

We want good data on how people are setting up sync, please uplift

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8e724faf0734