Closed Bug 1269909 Opened 6 years ago Closed 6 years ago

Add telemetry probe for clicking "Set up Sync" from History empty state

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox47 unaffected, firefox48+ fixed, firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox47 --- unaffected
firefox48 + fixed
firefox49 --- fixed

People

(Reporter: liuche, Assigned: liuche)

References

Details

Attachments

(1 file)

There isn't a telemetry probe for clicking on the button to set up sync from the History panel.
Assignee: nobody → liuche
Status: NEW → ASSIGNED
Comment on attachment 8748757 [details]
MozReview Request: Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle

https://reviewboard.mozilla.org/r/50519/#review47301

LGTM. We seem to be using the (action, button, extra) pattern for other empty panels.

The only oddball is the private browsing hint, which is a clickable span [1], and we use (action, panel, extra) for it. I suppose it's OK, but I wouldn't care if that got changed to "button" too, for some consistency in empty panel actions.

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryPanel.java#405
Attachment #8748757 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/123a7cac7ce9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment on attachment 8748757 [details]
MozReview Request: Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle

Approval Request Comment
[Feature/regressing bug #]: Didn't have telemetry in bug 1220928
[User impact if declined]: No telemetry for click actions
[Describe test coverage new/current, TreeHerder]: Nightly
[Risks and why]: very low, add probe
[String/UUID change made/needed]: none
Attachment #8748757 - Flags: approval-mozilla-aurora?
Comment on attachment 8748757 [details]
MozReview Request: Bug 1269909 - Add telemetry probe for clicking "Set up Sync" from History empty state. r=mfinkle

We want good data on how people are setting up sync, please uplift
Attachment #8748757 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.