[e10s] remote nsIOService::SpeculativeConnect to the parent

RESOLVED FIXED in Firefox 49

Status

()

Core
Networking: HTTP
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tedd, Assigned: bagder)

Tracking

unspecified
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox49 fixed)

Details

(Whiteboard: sblc1 [necko-active])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
After a discussion with :mcmanus regarding Bug 1259508, it seems that this should be remoted anyways, regardless of the sandboxing issue. 

See Bug 1259508 Comment 16, for further information.
(Reporter)

Comment 1

2 years ago
:bagder, I was told that you are probably the right person to work on this. I don't know how much work is required and how busy you are.

This is currently one of the last bugs blocking us from enabling seccomp on nightly. If you are too busy to work on this, I would write a workaround patch for Bug 1259508 which can then be backed out again once this bug is resolved.
Flags: needinfo?(daniel)
Component: General → Networking: HTTP
Product: Firefox → Core
Assignee: nobody → daniel
tracking-e10s: --- → ?
Whiteboard: sblc1 → sblc1 [necko-active]
(Assignee)

Comment 2

2 years ago
I'm moving this up to the top of my list. Just these national holidays (Sweden) in the way...
Flags: needinfo?(daniel)

Updated

2 years ago
tracking-e10s: ? → +
Priority: -- → P3
(Reporter)

Comment 3

2 years ago
Great thanks Daniel.
(Assignee)

Comment 4

2 years ago
Created attachment 8750252 [details] [diff] [review]
0001-Bug-1270147-remote-the-SpeculativeConnect-call-r-mcm.patch

Were you thinking about something as simple as this?

I'm not sure exactly how I should proceed to test this specifically. Any suggestions? (I'll send it off on a try-run of course.)
Attachment #8750252 - Flags: review?(mcmanus)
Attachment #8750252 - Flags: review?(mcmanus) → review+
to test this I think its sufficient to put print/log in the new code as well as the parent execution of the remoted call.. and then try and trigger it based on the stack in https://bug1259508.bmoattachments.org/attachment.cgi?id=8735522
(Assignee)

Comment 7

2 years ago
Wow, it wasn't that easy to actually trigger that code path but I've now tested it manually and the above try-run seems to agree. Good to merge methinks.
Keywords: checkin-needed

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aa2785a532d7
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.