1270148 - Search bar border color goes missing if it's moved out of the navbar

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[:Gijs (he/him)]

(applies to Windows & Linux, but not OS X)

https://dxr.mozilla.org/mozilla-central/rev/0a25833062a880f369e6f9f622413a94cc671bf4/browser/themes/linux/browser.css#817-830

If you move the search bar into the menu panel or another toolbar, the color goes away, and CSS warnings show up in the console/stderr.

We should define the variable on :root instead.

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1270148 - move urlbar-border-color definition to the window so the search bar doesn't lose its border styling when moved, r?jaws

Review commit: https://reviewboard.mozilla.org/r/50485/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50485/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8748689 [details]
MozReview Request: Bug 1270148 - move urlbar-border-color definition to the window so the search bar doesn't lose its border styling when moved, r?jaws

https://reviewboard.mozilla.org/r/50485/#review47269

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb5332bedc0e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fb5332bedc0e

Comment 5

[Md Maruf Rahman]

I have reproduced this bug with Nightly 49.0a1 (2016-05-04) on Windows 7, 64 Bit!

This bug's fix is verified with latest Beta 49.0b3.

 Build ID 	20160811031722
 User Agent     Mozilla/5.0(Windows NT 6.1; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0

[testday-20160812]