1270886 - Search bar shouldn't get lightweight theme treatment when placed in the menu panel

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

This change from bug 1270148:

-#nav-bar:-moz-lwtheme {
+#main-window:-moz-lwtheme {
   --urlbar-border-color: rgba(0,0,0,.3);
 }

... is wrong. The search bar's border color should only change for lightweight themes when the search bar is in a context where lightweight themes matter -- i.e. not in the menu panel.

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1270886 - only use lwtheme styling for search bar borders in the main toolbox, r?dao

This is still not completely perfect in that in principle it is possible for add-ons to add toolbars that they force to be non-transparent, but there is no way to select for that. Keeping a list of toolbars we know are transparent would break the more common case of third-party toolbars that do behave 'normally' when used with lightweight themes. So for now, just assume navigator-toolbox is all transparent when a lwtheme is in use.

Review commit: https://reviewboard.mozilla.org/r/51365/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51365/

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4dd60a8b9e2b

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4dd60a8b9e2b