Search bar shouldn't get lightweight theme treatment when placed in the menu panel

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dao, Assigned: Gijs)

Tracking

Trunk
Firefox 49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
This change from bug 1270148:

-#nav-bar:-moz-lwtheme {
+#main-window:-moz-lwtheme {
   --urlbar-border-color: rgba(0,0,0,.3);
 }

... is wrong. The search bar's border color should only change for lightweight themes when the search bar is in a context where lightweight themes matter -- i.e. not in the menu panel.
(Reporter)

Updated

3 years ago
Version: 48 Branch → Trunk
(Assignee)

Comment 1

3 years ago
Created attachment 8750349 [details]
MozReview Request: Bug 1270886 - only use lwtheme styling for search bar borders in the main toolbox, r?dao

This is still not completely perfect in that in principle it is possible for add-ons to add toolbars that they force to be non-transparent, but there is no way to select for that. Keeping a list of toolbars we know are transparent would break the more common case of third-party toolbars that do behave 'normally' when used with lightweight themes. So for now, just assume navigator-toolbox is all transparent when a lwtheme is in use.

Review commit: https://reviewboard.mozilla.org/r/51365/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51365/
Attachment #8750349 - Flags: review?(dao+bmo)
(Reporter)

Updated

3 years ago
Attachment #8750349 - Flags: review?(dao+bmo) → review+
(Assignee)

Updated

3 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

Comment 3

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4dd60a8b9e2b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in before you can comment on or make changes to this bug.