127025 - "Mozilla" hardcoded in pref-cache.dtd

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect)

Description

[Jonas Jørgensen]

From pref-cache.dtd:

<!ENTITY  diskCacheFolderExplanation    "Cache files will be stored in a
subfolder named &quot;Cache&quot; of the directory you specify. Restart Mozilla
for changes to take effect.">

Shouldn't "Mozilla" be "&brandShortName;" or something like that?

Comment 1

[Jonas Jørgensen]

Attachment: patch

This should do it.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 70780 [details] [diff] [review]
patch

r=bzbarsky

Comment 3

[Jonas Jørgensen]

Removing bug 123569 from OtherBugsDependingOnThis since this bug is neither
futured nor pushed out.

Comment 4

[jag (Peter Annema)]

Comment on attachment 70780 [details] [diff] [review]
patch

sr=jag

Comment 5

[Brendan Eich [:brendan]]

a=[e-mail] for drivers in 0.9.9.

/be

Comment 6

[Boris Zbarsky [:bzbarsky]]

checked into trunk for 0.9.9.

Comment 7

[Jonas Jørgensen]

Hmm... when I look at these two files, it doesn't look like the patch is applied:

http://lxr.mozilla.org/mozilla/source/xpfe/components/prefwindow/resources/locale/en-US/pref-cache.dtd
http://lxr.mozilla.org/mozilla/source/xpfe/components/prefwindow/resources/content/pref-cache.xul

And according to these two,

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/xpfe/components/prefwindow/resources/content&command=DIFF_FRAMESET&file=pref-cache.xul&rev1=1.50&rev2=1.51&root=/cvsroot
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/xpfe/components/prefwindow/resources/locale/en-US&command=DIFF_FRAMESET&file=pref-cache.dtd&rev1=1.17&rev2=1.18&root=/cvsroot

your checkin did not cause any changes to the files.

Comment 8

[Jonas Jørgensen]

Never mind my last comment. Now the last two URLs show the differences but the
first two still show the original file. I guess it just takes some time for LXR
and Bonsai to pick up the changes.

(Whoohoo, one of my patches have been checked in! Finally... :-) )

Comment 9

[Boris Zbarsky [:bzbarsky]]

Yeah, bonsai is usually 10 minutes to an hour behind, lxr is usually a few hours
behind.  :)