1270348 - Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''int android.graphics.Bitmap.getWidth()'' on a null object reference at org.mozilla.gecko.favicons.LoadFaviconTask.doInBackground(LoadFaviconTask.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-b386c1be-cfbd-4edc-9456-9df282160503.
=============================================================

At [1], I think it's possible for 'b' to be null in some unusual situations such as OOM or the icon contains a bitmap of size 0. We should gracefully ignore that instead of crashing.

[1] https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/favicons/LoadFaviconTask.java?rev=369a5ee3a288#448

Comment 1

[:Margaret Leibovic]

Blame points at bug 1238656.

Comment 2

[Andrzej Hunt :ahunt]

Attachment: MozReview Request: Bug 1270348 - Favicon decoder can return null Bitmaps r?sebastian

Review commit: https://reviewboard.mozilla.org/r/50891/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50891/

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8749357 [details]
MozReview Request: Bug 1270348 - Favicon decoder can return null Bitmaps r?sebastian

https://reviewboard.mozilla.org/r/50891/#review48041

Comment 4

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/6c0fd8ef15e3814e60e8e671ee185fdddc7be3c3
Bug 1270348 - Favicon decoder can return null Bitmaps r=sebastian

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6c0fd8ef15e3

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

Steps to reproduce in 1302808 comment 0.