Closed Bug 1270348 Opened 4 years ago Closed 4 years ago

Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''int android.graphics.Bitmap.getWidth()'' on a null object reference at org.mozilla.gecko.favicons.LoadFaviconTask.doInBackground(LoadFaviconTask.java)

Categories

(Firefox for Android :: Favicon Handling, defect, critical)

Unspecified
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- affected
firefox49 --- fixed

People

(Reporter: jchen, Assigned: ahunt)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-b386c1be-cfbd-4edc-9456-9df282160503.
=============================================================

At [1], I think it's possible for 'b' to be null in some unusual situations such as OOM or the icon contains a bitmap of size 0. We should gracefully ignore that instead of crashing.

[1] https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/favicons/LoadFaviconTask.java?rev=369a5ee3a288#448
Blame points at bug 1238656.
Assignee: nobody → ahunt
Blocks: 1238656
Flags: needinfo?(ahunt)
Status: NEW → ASSIGNED
Flags: needinfo?(ahunt)
Comment on attachment 8749357 [details]
MozReview Request: Bug 1270348 - Favicon decoder can return null Bitmaps r?sebastian

https://reviewboard.mozilla.org/r/50891/#review48041
Attachment #8749357 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/mozilla-central/rev/6c0fd8ef15e3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Duplicate of this bug: 1302808
Steps to reproduce in 1302808 comment 0.
You need to log in before you can comment on or make changes to this bug.