Closed Bug 1270366 Opened 4 years ago Closed 3 years ago

PluginArray and Plugin should have unenumerable own properties per spec

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox49 --- wontfix
firefox50 --- wontfix
firefox51 --- wontfix
firefox52 --- wontfix
firefox53 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: addon-compat, dev-doc-complete, site-compat, Whiteboard: btpp-fixlater)

Attachments

(1 file)

It's not clear to me why the spec says this, though.  They're certainly enumerable in Firefox...  Anne, do you know?

Changing this could include some compat pain, unfortunately.
Flags: needinfo?(annevk)
Depends on: 1270349
You discussed this with Ian back in 2013: https://www.w3.org/Bugs/Public/show_bug.cgi?id=22600 (found through grepping through the spec commit log for unenumerable).
Flags: needinfo?(annevk)
Whiteboard: btpp-fixlater
I didn't bother adding tests, because this is all only observable if there are plugins installed, and all that stuff is on its way out, so it's hard to write a meaningful test.
Attachment #8786586 - Flags: review?(bkelly)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8786586 - Flags: review?(bkelly) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf6badc0622b
PluginArray and Plugin should have unenumerable named properties.  r=bkelly
https://hg.mozilla.org/mozilla-central/rev/cf6badc0622b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Backed out per bug 757726 comment 161 for now, until we kill off plugins and can make the change more safely.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Backout by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3319f311285f
Backed out changeset cf6badc0622b per discussion in bug 757726 (starting somewhere around bug 757726 comment 157).
Blocks: 757726
Depends on: npapi-eol
https://hg.mozilla.org/mozilla-central/rev/3319f311285f
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Not fixed at all.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(bzbarsky)
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/593a22cf5376
PluginArray and Plugin should have unenumerable named properties.  r=bkelly
Flags: needinfo?(bzbarsky)
https://hg.mozilla.org/mozilla-central/rev/593a22cf5376
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
I've added notes about this to:

https://developer.mozilla.org/en-US/docs/Web/API/Plugin
https://developer.mozilla.org/en-US/docs/Web/API/PluginArray
https://developer.mozilla.org/en-US/Firefox/Releases/53#DOM_HTML_DOM

I don't think I need to worry about adding more details to the pages, given that this stuff is on the way out. Let me know if you'd like me to add anything else. Thanks!
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.