PluginArray and Plugin should have unenumerable own properties per spec

RESOLVED FIXED in Firefox 53

Status

()

Core
DOM
RESOLVED FIXED
a year ago
3 months ago

People

(Reporter: bz, Assigned: bz)

Tracking

({addon-compat, dev-doc-complete, site-compat})

Trunk
mozilla51
addon-compat, dev-doc-complete, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 wontfix, firefox50 wontfix, firefox51 wontfix, firefox52 wontfix, firefox53 fixed)

Details

(Whiteboard: btpp-fixlater)

Attachments

(1 attachment)

It's not clear to me why the spec says this, though.  They're certainly enumerable in Firefox...  Anne, do you know?

Changing this could include some compat pain, unfortunately.
Flags: needinfo?(annevk)
Depends on: 1270349

Comment 1

a year ago
You discussed this with Ian back in 2013: https://www.w3.org/Bugs/Public/show_bug.cgi?id=22600 (found through grepping through the spec commit log for unenumerable).
Flags: needinfo?(annevk)
Whiteboard: btpp-fixlater
Created attachment 8786586 [details] [diff] [review]
PluginArray and Plugin should have unenumerable named properties

I didn't bother adding tests, because this is all only observable if there are plugins installed, and all that stuff is on its way out, so it's hard to write a meaningful test.
Attachment #8786586 - Flags: review?(bkelly)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8786586 - Flags: review?(bkelly) → review+

Comment 3

9 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf6badc0622b
PluginArray and Plugin should have unenumerable named properties.  r=bkelly

Comment 4

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cf6badc0622b
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
status-firefox49: affected → wontfix

Updated

9 months ago
Keywords: addon-compat, dev-doc-needed, site-compat
Backed out per bug 757726 comment 161 for now, until we kill off plugins and can make the change more safely.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 6

9 months ago
Backout by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3319f311285f
Backed out changeset cf6badc0622b per discussion in bug 757726 (starting somewhere around bug 757726 comment 157).

Updated

9 months ago
Blocks: 757726
Depends on: 1269807

Comment 7

8 months ago
backoutbugherder
https://hg.mozilla.org/mozilla-central/rev/3319f311285f
Status: REOPENED → RESOLVED
Last Resolved: 9 months ago8 months ago
Resolution: --- → FIXED
Not fixed at all.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

8 months ago
status-firefox50: --- → wontfix
status-firefox51: fixed → wontfix
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/navigator-plugins-and-mimetypes-will-be-unenumerable/
Flags: needinfo?(bzbarsky)

Comment 10

6 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/593a22cf5376
PluginArray and Plugin should have unenumerable named properties.  r=bkelly
Flags: needinfo?(bzbarsky)
status-firefox52: --- → wontfix
status-firefox53: --- → affected

Comment 11

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/593a22cf5376
Status: REOPENED → RESOLVED
Last Resolved: 8 months ago6 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
I've added notes about this to:

https://developer.mozilla.org/en-US/docs/Web/API/Plugin
https://developer.mozilla.org/en-US/docs/Web/API/PluginArray
https://developer.mozilla.org/en-US/Firefox/Releases/53#DOM_HTML_DOM

I don't think I need to worry about adding more details to the pages, given that this stuff is on the way out. Let me know if you'd like me to add anything else. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.