1270366 - PluginArray and Plugin should have unenumerable own properties per spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It's not clear to me why the spec says this, though.  They're certainly enumerable in Firefox...  Anne, do you know?

Changing this could include some compat pain, unfortunately.

Comment 1

[Anne (:annevk)]

You discussed this with Ian back in 2013: https://www.w3.org/Bugs/Public/show_bug.cgi?id=22600 (found through grepping through the spec commit log for unenumerable).

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: PluginArray and Plugin should have unenumerable named properties

I didn't bother adding tests, because this is all only observable if there are plugins installed, and all that stuff is on its way out, so it's hard to write a meaningful test.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf6badc0622b
PluginArray and Plugin should have unenumerable named properties.  r=bkelly

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cf6badc0622b

Comment 5

[Boris Zbarsky [:bzbarsky]]

Backed out per bug 757726 comment 161 for now, until we kill off plugins and can make the change more safely.

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3319f311285f
Backed out changeset cf6badc0622b per discussion in bug 757726 (starting somewhere around bug 757726 comment 157).

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3319f311285f

Comment 8

[Boris Zbarsky [:bzbarsky]]

Not fixed at all.

Comment 9

[Kohei Yoshino]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/navigator-plugins-and-mimetypes-will-be-unenumerable/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/593a22cf5376
PluginArray and Plugin should have unenumerable named properties.  r=bkelly

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/593a22cf5376

Comment 12

[Chris Mills [:cmills]]

I've added notes about this to:

https://developer.mozilla.org/en-US/docs/Web/API/Plugin
https://developer.mozilla.org/en-US/docs/Web/API/PluginArray
https://developer.mozilla.org/en-US/Firefox/Releases/53#DOM_HTML_DOM

I don't think I need to worry about adding more details to the pages, given that this stuff is on the way out. Let me know if you'd like me to add anything else. Thanks!