1270349 - Implement [LegacyUnenumerableNamedProperties] in IDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See https://github.com/heycam/webidl/pull/91

The idea is that instead of asking the object on a per-name basis whether it's enumerable or not, we just annotate in the IDL whether the named props are enumerable.  Then we can have codegen do the right thing and I think we can get rid of both NameIsEnumerable() on various classes and the flags argument to GetSupportedNames.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Add IDL parser support for [LegacyUnenumerableNamedProperties]

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Add [LegacyUnenumerableNamedProperties] to the interfaces that specify it in DOM and HTML

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Add a way to ask an interface descriptor for a proxy whether its named props should be enumerable

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Use LegacyUnenumerableNamedProperties instead of NameIsEnumerable() calls to determine whether named props on DOM proxies should be enumerable

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Use LegacyUnenumerableNamedProperties instead of passing flags to GetSupportedNames to determine whether named props on DOM proxies should be reflected in ownPropertyKeys

Comment 6

[Peter Van der Beken [:peterv]]

Comment on attachment 8749048 [details] [diff] [review]
part 2.  Add [LegacyUnenumerableNamedProperties] to the interfaces that specify it in DOM and HTML

Review of attachment 8749048 [details] [diff] [review]:
-----------------------------------------------------------------

Window seems to be missing though?

Comment 7

[Boris Zbarsky [:bzbarsky]]

> Window seems to be missing though?

Yeah, we don't codegen the proxy for Window, because it's the named properties handler instead.

I could add it there, and I guess I should, but it won't do anything.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c13bb8a0b16b
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3361d3f04b3
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a29d3bb1b6b
https://hg.mozilla.org/integration/mozilla-inbound/rev/db1255660184
https://hg.mozilla.org/integration/mozilla-inbound/rev/29ee431f3921

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c13bb8a0b16b
https://hg.mozilla.org/mozilla-central/rev/a3361d3f04b3
https://hg.mozilla.org/mozilla-central/rev/4a29d3bb1b6b
https://hg.mozilla.org/mozilla-central/rev/db1255660184
https://hg.mozilla.org/mozilla-central/rev/29ee431f3921

Comment 10

[Peter Van der Beken [:peterv]]

Comment on attachment 8749053 [details] [diff] [review]
part 5.  Use LegacyUnenumerableNamedProperties instead of passing flags to GetSupportedNames to determine whether named props on DOM proxies should be reflected in ownPropertyKeys

Review of attachment 8749053 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsMimeTypeArray.cpp
@@ +130,5 @@
>    return mMimeTypes.Length();
>  }
>  
>  void
> +nsMimeTypeArray::GetSupportedNames(nsTArray< nsString >& aRetval)

Maybe remove the spaces inside <> here too?

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2bea300363a6

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2bea300363a6

Comment 13

[Jukka Jylänki]

Either this bug or bug 1268047 regressed being able to upload photos to dpreview.com photography community forums. See bug 1310414.

Comment 14

[Boris Zbarsky [:bzbarsky]]

That would have been bug 1268047.