Closed Bug 1270820 Opened 4 years ago Closed 4 years ago

Improve failure messages for Wait().until() calls in Firefox UI testcase classes

Categories

(Testing :: Firefox UI Tests, defect)

defect
Not set

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1258385 +++

Our current calls for Wait().until() don't have set any message in case of a timeout. We should do that so we get more details in what's wrong with it. Means messages like what we have currently are not that helpful and will not allow us to star failures correctly on Treeherder:

> TimeoutException: Timed out after 5.0 seconds
Clicked Return too early... So this bug is indeed not about Puppeteer but the harness. With bug 1258385 I updated all modules for puppeteer but sadly missed the testcase classes for Firefox UI harness. It should be done ASAP so we can get meaningful failure reports.
Assignee: nobody → hskupin
No longer blocks: 1256425
Status: NEW → ASSIGNED
Summary: Improve failure messages for Wait().until() calls in Firefox Puppeteer → Improve failure messages for Wait().until() calls in Firefox UI testcase classes
Comment on attachment 8749677 [details]
MozReview Request: Bug 1270820 - Improve failure messages for Wait().until() calls in Firefox UI testcase classes. r?maja_zf

https://reviewboard.mozilla.org/r/51089/#review47771
Attachment #8749677 - Flags: review?(mjzffr) → review+
https://hg.mozilla.org/mozilla-central/rev/c7b7c9a6438d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Fix for the tests works pretty fine. Lets get this backported to mozilla-aurora.

In case we also want this for mozilla-beta a separate patch would be necessary because the file is at another location on that branch: http://mxr.mozilla.org/mozilla-beta/source/testing/puppeteer/firefox/firefox_puppeteer/testcases/update.py
Whiteboard: [checkin-needed-aurora]
As long as there is no immediate need to have more descriptive messages for those until() calls for 47.0 and 45.0esr, I would not work on a backport fix.
You need to log in before you can comment on or make changes to this bug.