Closed
Bug 1270820
Opened 8 years ago
Closed 8 years ago
Improve failure messages for Wait().until() calls in Firefox UI testcase classes
Categories
(Testing :: Firefox UI Tests, defect)
Testing
Firefox UI Tests
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
mozilla49
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1258385 +++ Our current calls for Wait().until() don't have set any message in case of a timeout. We should do that so we get more details in what's wrong with it. Means messages like what we have currently are not that helpful and will not allow us to star failures correctly on Treeherder: > TimeoutException: Timed out after 5.0 seconds
Assignee | ||
Comment 1•8 years ago
|
||
Clicked Return too early... So this bug is indeed not about Puppeteer but the harness. With bug 1258385 I updated all modules for puppeteer but sadly missed the testcase classes for Firefox UI harness. It should be done ASAP so we can get meaningful failure reports.
Assignee: nobody → hskupin
No longer blocks: 1256425
Status: NEW → ASSIGNED
Summary: Improve failure messages for Wait().until() calls in Firefox Puppeteer → Improve failure messages for Wait().until() calls in Firefox UI testcase classes
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51089/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51089/
Attachment #8749677 -
Flags: review?(mjzffr)
Comment on attachment 8749677 [details] MozReview Request: Bug 1270820 - Improve failure messages for Wait().until() calls in Firefox UI testcase classes. r?maja_zf https://reviewboard.mozilla.org/r/51089/#review47771
Attachment #8749677 -
Flags: review?(mjzffr) → review+
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c7b7c9a6438d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Assignee | ||
Comment 6•8 years ago
|
||
Fix for the tests works pretty fine. Lets get this backported to mozilla-aurora. In case we also want this for mozilla-beta a separate patch would be necessary because the file is at another location on that branch: http://mxr.mozilla.org/mozilla-beta/source/testing/puppeteer/firefox/firefox_puppeteer/testcases/update.py
status-firefox47:
--- → affected
status-firefox48:
--- → affected
Whiteboard: [checkin-needed-aurora]
Comment 7•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/1010a952f966
Whiteboard: [checkin-needed-aurora]
Assignee | ||
Comment 8•8 years ago
|
||
As long as there is no immediate need to have more descriptive messages for those until() calls for 47.0 and 45.0esr, I would not work on a backport fix.
status-firefox47:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•