Closed Bug 1270867 Opened 4 years ago Closed 4 years ago

confusing error message when I was just searching for a bug

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Production
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jmaher, Assigned: dylan)

Details

Attachments

(1 file, 1 obsolete file)

I went to:
https://bugzilla.mozilla.org/

and in the single search box, I entered:
Channel timeout: cannot send/recv

and I get this message:
There is a problem with your search:

timeout is not a valid field name.

The legal field names are listed here.


what does legal field name mean, is that valid field name?  why didn't it search bugzilla for my string?
quicksearch deficiency in that it treats field:value as shortcuts for field = value so it thinks your timeout: part is a field in Bugzilla. We should look at treating it as plain string if it does not match any known field.

dkl
The parser is some serious scary code, but we can probably ignore colons followed by spaces.
Assignee: nobody → dylan
and get rid of the 'legal' word, that made me think I was on a spoofed website and had to triple check the url.
Attached patch 1270536_1.patch (obsolete) — Splinter Review
Also changed "legal" to "valid" per joel's suggestion.
Attachment #8749744 - Flags: review?(dkl)
Comment on attachment 8749744 [details] [diff] [review]
1270536_1.patch

Review of attachment 8749744 [details] [diff] [review]:
-----------------------------------------------------------------

Wrong patch for this bug :)
Attachment #8749744 - Flags: review?(dkl) → review-
Attached patch 1270867_1.patchSplinter Review
Attachment #8749744 - Attachment is obsolete: true
Attachment #8750764 - Flags: review?(dkl)
Comment on attachment 8750764 [details] [diff] [review]
1270867_1.patch

Review of attachment 8750764 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

::: template/en/default/global/user-error.html.tmpl
@@ +1662,4 @@
>      [% END %]
>  
>      [% IF unknown.size %]
> +      <p>The valid field names are 

remove trailing whitespace
Attachment #8750764 - Flags: review?(dkl) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   44a2e60..627be9d  master -> master
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.