1271146 - Add Chrome's CMD+SHIFT+N keyboard shortcut as an alias for "New Private Window" menu command

Status: RESOLVED WONTFIX

(Firefox :: Keyboard Navigation, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: new-private-window-shortcut.patch

CMD+SHIFT+P is the keyboard shortcut to open a new Private Browsing window in Firefox, IE, and Edge. CMD+SHIFT+N is the keyboard shortcut to open a new Private Browsing window in Chrome and Safari.

CMD+SHIFT+N is not reserved for any other Firefox keyboard shortcut, so we can use it as a secondary alias to reduce unnecessary annoyance or relearning for Chrome and Safari users using Firefox.

Comment 1

[Marco Bonardo [:mak]]

Comment on attachment 8750112 [details] [diff] [review]
new-private-window-shortcut.patch

Review of attachment 8750112 [details] [diff] [review]:
-----------------------------------------------------------------

I think it would be a good idea...

Unfortunately it's conflicting with "Undo close window".
<key id="key_undoCloseWindow" command="History:UndoCloseWindow" key="&newNavigatorCmd.key;" modifiers="accel,shift"/>
<!ENTITY newNavigatorCmd.key "N">

And this is likely why we never did it.
Now, the "Undo close window" command may have less value than "New private window", so we could evaluate changing that, but it would not be coherent anymore with Undo close tab...
Chrome workarounds that by not offering a shortcut for "Undo close window", instead one can undo closed tabs until it reaches a tab in another window, then the window is restored.

Changing our Undo close window behavior is not a decision I can take, you should evaluate it with UX and management.

Comment 2

[Chris Peterson [:cpeterson]]

oops. I didn't see that CMD+SHIFT+N was already in use. I will WONTFIX this bug because I don't think we should remove an existing keyboard shortcut just to make an undocumented alias for another shortcut.