471428 - Add Ctrl+Shift+P keyboard shortcut for private browsing mode

Status: VERIFIED FIXED

(Firefox :: Private Browsing, enhancement)

Description

[(no longer active)]

This has came up several times so far.  I think we need one, both for Mac, where menu items can't be invoked using keyboard shortcuts, and many cases like <http://groups.google.com/group/mozilla.dev.apps.firefox/msg/88b1d4770cdd0b49>.  It's also a lot more convenient for keyboard savvy users.

What do others think?

Comment 2

[Tyler Downer [He/Him]]

Enhancement request, but seems good.

Comment 3

[Dave Garrett]

You can open a new window with a hotkey and a new tab with a hotkey, so it follows reason that you should be able to open a new private window with a hotkey as well. If ctrl+shift+P isn't taken I think this is a must have. (if just because people keep requesting it)

Oh, and congratulations on creating a dupe of a bug in which you've already commented...  :p

Comment 4

[(no longer active)]

(In reply to comment #3)
> You can open a new window with a hotkey and a new tab with a hotkey, so it
> follows reason that you should be able to open a new private window with a
> hotkey as well. If ctrl+shift+P isn't taken I think this is a must have. (if
> just because people keep requesting it)

Yes, I think Ctrl+Shift+P is available, and it's the most logical keyboard shortcut combination I can think of...

> Oh, and congratulations on creating a dupe of a bug in which you've already
> commented...  :p

Now, on to creating a dupe of a bug which I've filed myself!  ;-)

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

Yes, I think Ctrl+Shift+P is available, and it's the most logical keyboard
shortcut combination I can think of...

Sounds good, if we switch to a window mode later we might want to also pick up control-shift-n, similar to Chrome (but still keeping the old shortcut for consistency).

>Now, on to creating a dupe of a bug which I've filed myself!  ;-)

I actually do that all the time myself, my theory is that a dupe is better than forgetting to file :)

Comment 6

[(no longer active)]

Attachment: Patch (v1)

This needs to land before the string freeze, and it should be a trivial review as well; but at any rate the string part can land before the code.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 355003 [details] [diff] [review]
Patch (v1)

uir=beltzner but with some objections

I'm giving this ui-r and approval191 to beat string freeze. I am not, however, completely certain that we want this shortcut.

Shortcuts are meant as quick routes to common actions (cut, copy, paste, new tab). Entering and exiting Private Browsing Mode is unlikely to be the sort of thing people do frequently, and the cost of accidentally hitting the shortcut (when fat-fingering the key combination for Print) and of adding Yet Another Shortcut to the list along the side isn't something we should ignore.

Basically what I'm saying is that I'm reserving the right that I always have to request that this be removed afterwards.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/a980f7c6189d
https://hg.mozilla.org/releases/mozilla-1.9.1/rev/7bf46bafcf36

Comment 9

[Marcia Knous [:marcia]]

verified fixed on the 1.9.1 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090102 Shiretoko/3.1b3pre and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090102 Shiretoko/3.1b3pre. Adding keyword.

verified fixed on the trunk using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090102 Minefield/3.2a1pre and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090102 Minefield/3.2a1pre

Comment 10

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7443

Comment 11

[Joshua Barr]

This conflicts with Firebug's Profile JavaScript keyboard shortcut. Just sayin'.

Comment 12

[Mike Connor [:mconnor]]

File a report with Firebug.  Just sayin'.

Comment 13

[Joshua Barr]

Already did, before making that comment :D

Comment 14

[Chris Ilias [:cilias]]

user-doc-complete
<https://support.mozilla.com/kb/Keyboard+shortcuts?bl=n>

Comment 15

[(no longer active)]

This is covered to a good extent by the PB UI tests.  Testing that a <key> element actually triggers the command when the key combination is pressed is outside the scope for this bug.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #15)
> This is covered to a good extent by the PB UI tests.  Testing that a <key>
> element actually triggers the command when the key combination is pressed is
> outside the scope for this bug.

Ehsan, do you have a link to those tests? Would be nice to reference them in a bug so it's less pain to search for them.

Comment 17

[(no longer active)]

(In reply to comment #16)
> (In reply to comment #15)
> > This is covered to a good extent by the PB UI tests.  Testing that a <key>
> > element actually triggers the command when the key combination is pressed is
> > outside the scope for this bug.
> 
> Ehsan, do you have a link to those tests? Would be nice to reference them in a
> bug so it's less pain to search for them.

Sure: http://mxr.mozilla.org/mozilla-central/source/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_ui.js