[Windows] previous/next button icons need HiDPI versions

RESOLVED FIXED in Firefox 49

Status

()

Toolkit
Find Toolbar
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jaws, Assigned: mikedeboer)

Tracking

unspecified
mozilla49
Points:
2
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Bug 896304 added versions of these icons for OSX but not for Windows, where they are needed too.
(Assignee)

Updated

2 years ago
Priority: -- → P1
(Assignee)

Updated

2 years ago
Summary: [Windows] magnifying glass icon and previous/next button icons need HiDPI versions → [Windows] previous/next button icons need HiDPI versions
(Assignee)

Comment 1

2 years ago
Stephen, can I use the same arrow icons as on OSX (svg) or would you like to provide me with different ones?
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Flags: needinfo?(shorlander)
(In reply to Mike de Boer [:mikedeboer] from comment #1)
> Stephen, can I use the same arrow icons as on OSX (svg) or would you like to
> provide me with different ones?

Yes, you can use the same icons.
Flags: needinfo?(shorlander)
While you are here, why not use them on Linux too?
(Assignee)

Comment 4

2 years ago
(In reply to Panos Astithas [:past] from comment #3)
> While you are here, why not use them on Linux too?

Consider it done.

Updated

2 years ago
No longer blocks: 896304
Depends on: 896304
(Assignee)

Comment 5

2 years ago
Created attachment 8752166 [details] [diff] [review]
Patch v1: use scalable SVG icons for the findbar navigation arrows
Attachment #8752166 - Flags: review?(dao+bmo)
(Assignee)

Updated

2 years ago
Iteration: --- → 49.2 - May 23
Points: --- → 2
Comment on attachment 8752166 [details] [diff] [review]
Patch v1: use scalable SVG icons for the findbar navigation arrows

Hm, should we add an outline to the SVG icon so that it's visible on different backgrounds? It currently seems to use just a single fill color. We could also use -moz-dialogtext as the fill color, but we'd need to take care of lightweight themes too.
Attachment #8752166 - Flags: review?(dao+bmo)
(Assignee)

Comment 7

2 years ago
Good point! Let's ask Stephen if he wants to adjust the SVG - in case a drop-shadow style outline is preferred - or define a stroke. In any case I'd like to know the color value of this stroke.
Lightweight themes are not applied to the findbar.
Flags: needinfo?(shorlander)
If lightweight themes aren't a concern, we can just use -moz-dialogtext instead of #4c4c4c, right?
(In reply to Dão Gottwald [:dao] from comment #8)
> If lightweight themes aren't a concern, we can just use -moz-dialogtext
> instead of #4c4c4c, right?

That should probably work. I think we are applying a gradient overlay on those buttons though. So that would probably need to be removed or the effect reduced to avoid potential conflicts.
Flags: needinfo?(shorlander)
(Assignee)

Comment 10

2 years ago
-moz-dialogtext is rather black on my windows box... is that correct? And if so, is that the intended look?
It's in fact 100% black with default settings on Windows, just like the text in the find bar. Matching the text color sounds right to me.
I agree with Dao, this should be -moz-dialogtext and it will be fine that it is black. As it is right now on Windows 10 they are a dark navy blue which doesn't match any of the other colors in the findbar.
(Assignee)

Comment 13

2 years ago
Created attachment 8753490 [details] [diff] [review]
Patch v2: use scalable SVG icons for the findbar navigation arrows
Attachment #8752166 - Attachment is obsolete: true
Attachment #8753490 - Flags: review?(dao+bmo)
Comment on attachment 8753490 [details] [diff] [review]
Patch v2: use scalable SVG icons for the findbar navigation arrows

I think this will work fine. If we find that it's too dark, we can still reduce the opacity.
Attachment #8753490 - Flags: review?(dao+bmo) → review+
(Assignee)

Comment 15

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/f79314b1a23fa5fd403fbcf97b81a59a800d9614
Bug 1271680 - use scalable SVG icons for the findbar navigation arrows on Windows and Linux too. r=dao

Comment 16

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f79314b1a23f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49

Updated

2 years ago
Blocks: 334578
You need to log in before you can comment on or make changes to this bug.