1271680 - [Windows] previous/next button icons need HiDPI versions

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Bug 896304 added versions of these icons for OSX but not for Windows, where they are needed too.

Comment 1

[Mike de Boer [:mikedeboer]]

Stephen, can I use the same arrow icons as on OSX (svg) or would you like to provide me with different ones?

Comment 2

[Stephen Horlander [:shorlander] (If you're waiting on a response please ping me on Slack or Riot)]

(In reply to Mike de Boer [:mikedeboer] from comment #1)
> Stephen, can I use the same arrow icons as on OSX (svg) or would you like to
> provide me with different ones?

Yes, you can use the same icons.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

While you are here, why not use them on Linux too?

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to Panos Astithas [:past] from comment #3)
> While you are here, why not use them on Linux too?

Consider it done.

Comment 5

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: use scalable SVG icons for the findbar navigation arrows

Comment 6

[Dão Gottwald [::dao]]

Comment on attachment 8752166 [details] [diff] [review]
Patch v1: use scalable SVG icons for the findbar navigation arrows

Hm, should we add an outline to the SVG icon so that it's visible on different backgrounds? It currently seems to use just a single fill color. We could also use -moz-dialogtext as the fill color, but we'd need to take care of lightweight themes too.

Comment 7

[Mike de Boer [:mikedeboer]]

Good point! Let's ask Stephen if he wants to adjust the SVG - in case a drop-shadow style outline is preferred - or define a stroke. In any case I'd like to know the color value of this stroke.
Lightweight themes are not applied to the findbar.

Comment 8

[Dão Gottwald [::dao]]

If lightweight themes aren't a concern, we can just use -moz-dialogtext instead of #4c4c4c, right?

Comment 9

[Stephen Horlander [:shorlander] (If you're waiting on a response please ping me on Slack or Riot)]

(In reply to Dão Gottwald [:dao] from comment #8)
> If lightweight themes aren't a concern, we can just use -moz-dialogtext
> instead of #4c4c4c, right?

That should probably work. I think we are applying a gradient overlay on those buttons though. So that would probably need to be removed or the effect reduced to avoid potential conflicts.

Comment 10

[Mike de Boer [:mikedeboer]]

-moz-dialogtext is rather black on my windows box... is that correct? And if so, is that the intended look?

Comment 11

[Dão Gottwald [::dao]]

It's in fact 100% black with default settings on Windows, just like the text in the find bar. Matching the text color sounds right to me.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

I agree with Dao, this should be -moz-dialogtext and it will be fine that it is black. As it is right now on Windows 10 they are a dark navy blue which doesn't match any of the other colors in the findbar.

Comment 13

[Mike de Boer [:mikedeboer]]

Attachment: Patch v2: use scalable SVG icons for the findbar navigation arrows

Comment 14

[Dão Gottwald [::dao]]

Comment on attachment 8753490 [details] [diff] [review]
Patch v2: use scalable SVG icons for the findbar navigation arrows

I think this will work fine. If we find that it's too dark, we can still reduce the opacity.

Comment 15

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/integration/fx-team/rev/f79314b1a23fa5fd403fbcf97b81a59a800d9614
Bug 1271680 - use scalable SVG icons for the findbar navigation arrows on Windows and Linux too. r=dao

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f79314b1a23f