1271698 - Put recent URL bar changes behind Switchboard flags.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

We want to put behind Switchboard flags:

* Showing origin only in URL bar (bug 1236431)
* Show name of organization (EV certificate) (bug 1249594)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1271698 - Add Switchboard flags for URL bar changes. r?margaret

* urlbar-show-origin-only: Only show origin in URL bar instead of full URL (Bug 1236431)
* urlbar-show-ev-cert-owner: Show name of organization (EV cert) instead of full URL in URL bar (Bug 1249594)

Review commit: https://reviewboard.mozilla.org/r/51911/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51911/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: (GitHub) Switchboard Config: Bug 1271698 - Add experiments for URL bar changes.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

For now the experiment is only enabled on Nightly, Aurora and Beta.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

It might be good to create some guidelines for creating experiments vs staging rollouts. In this case, do we need a different experiment for each variation? Or could we use a single experiment ("urlbar-show") and have sub-variables for the other state?

Comment 5

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> It might be good to create some guidelines for creating experiments vs
> staging rollouts. In this case, do we need a different experiment for each
> variation? Or could we use a single experiment ("urlbar-show") and have
> sub-variables for the other state?

We could use experiment values for enabling the sub-parts of the feature. However, we will have less control if that's the case, since match/buckets would only apply to the entire experiment. For example, we couldn't turn on only the origin part for release, but keep the EV cert owner enabled up to beta.

What problems do you identify with different experiments for each variation? I understand it's more things to keep track of, and can lead to a long list of experiments, but I like that it is more explicit.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

At first I wanted to create just one experiment but then I created two. Just because I do not want to get back to it if we decide that we want to show the origin but want to revert the EV certificate changes.

Comment 7

[:Margaret Leibovic]

Comment on attachment 8751220 [details]
MozReview Request: Bug 1271698 - Add Switchboard flags for URL bar changes. r?margaret

https://reviewboard.mozilla.org/r/51911/#review48751

Comment 8

[:Margaret Leibovic]

Comment on attachment 8751223 [details] [review]
(GitHub) Switchboard Config: Bug 1271698 - Add experiments for URL bar changes.

This doesn't require relman approval, since it won't actually change anything until your patch is uplifted. So feel free to merge whenever.

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/dfb23d172953e063e321c20feec282e955230310
Bug 1271698 - Add Switchboard flags for URL bar changes. r=margaret

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8751220 [details]
MozReview Request: Bug 1271698 - Add Switchboard flags for URL bar changes. r?margaret

Approval Request Comment

[Feature/regressing bug #]: We want to put the changes from bug 1236431 and bug 1249594 behind switchboard flags to control the release of this feature while we evaluate the user feedback we received. The switchboard configuration keeps the features enabled on Nightly, Aurora and Beta. The features are not in release yet but after the merge day we can use switchboard to decide if we want to roll this out or not.

[User impact if declined]: Without that the features will ride the trains to release after the next merge day and we might not have enough time left to make changes based on the feedback.

[Describe test coverage new/current, TreeHerder]: Local testing.

[Risks and why]: Low - This patch just adds the switchboard experiments and falls back to the default behavior for URLs if the user is in no experiment.

[String/UUID change made/needed]: -

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/dfb23d172953

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8751220 [details]
MozReview Request: Bug 1271698 - Add Switchboard flags for URL bar changes. r?margaret

Switchboard flags for dynamic control of feature per channel. Aurora48+, Beta47+

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Hitting conflicts uplifting to aurora.

Comment 14

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1271698-urlbar-AURORA.patch

Modified patch for Aurora.

Comment 15

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1271698-urlbar-BETA.patch

Modified patch for Beta.

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Wes, just fyi, the rebased patches are ready to land on m-b. Thanks!

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4f1d54f271ce

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f0f690f287d8

Comment 19

[Sorina Florean [:sflorean]]

Verified as fixed in build:
- Aurora 48.0a2 (2016-05-26);
- Nightly 49.0a1 (2016-05-26);
Device: LG G4 (Android 5.1)