Closed Bug 1271698 Opened 4 years ago Closed 4 years ago

Put recent URL bar changes behind Switchboard flags.

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
firefox47 --- fixed
firefox48 --- verified
firefox49 --- verified
fennec 47+ ---

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(4 files)

We want to put behind Switchboard flags:

* Showing origin only in URL bar (bug 1236431)
* Show name of organization (EV certificate) (bug 1249594)
tracking-fennec: --- → 47+
* urlbar-show-origin-only: Only show origin in URL bar instead of full URL (Bug 1236431)
* urlbar-show-ev-cert-owner: Show name of organization (EV cert) instead of full URL in URL bar (Bug 1249594)

Review commit: https://reviewboard.mozilla.org/r/51911/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51911/
Attachment #8751220 - Flags: review?(margaret.leibovic)
For now the experiment is only enabled on Nightly, Aurora and Beta.
It might be good to create some guidelines for creating experiments vs staging rollouts. In this case, do we need a different experiment for each variation? Or could we use a single experiment ("urlbar-show") and have sub-variables for the other state?
(In reply to Mark Finkle (:mfinkle) from comment #4)
> It might be good to create some guidelines for creating experiments vs
> staging rollouts. In this case, do we need a different experiment for each
> variation? Or could we use a single experiment ("urlbar-show") and have
> sub-variables for the other state?

We could use experiment values for enabling the sub-parts of the feature. However, we will have less control if that's the case, since match/buckets would only apply to the entire experiment. For example, we couldn't turn on only the origin part for release, but keep the EV cert owner enabled up to beta.

What problems do you identify with different experiments for each variation? I understand it's more things to keep track of, and can lead to a long list of experiments, but I like that it is more explicit.
At first I wanted to create just one experiment but then I created two. Just because I do not want to get back to it if we decide that we want to show the origin but want to revert the EV certificate changes.
Comment on attachment 8751220 [details]
MozReview Request: Bug 1271698 - Add Switchboard flags for URL bar changes. r?margaret

https://reviewboard.mozilla.org/r/51911/#review48751
Attachment #8751220 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8751223 [details] [review]
(GitHub) Switchboard Config: Bug 1271698 - Add experiments for URL bar changes.

This doesn't require relman approval, since it won't actually change anything until your patch is uplifted. So feel free to merge whenever.
Attachment #8751223 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8751220 [details]
MozReview Request: Bug 1271698 - Add Switchboard flags for URL bar changes. r?margaret

Approval Request Comment

[Feature/regressing bug #]: We want to put the changes from bug 1236431 and bug 1249594 behind switchboard flags to control the release of this feature while we evaluate the user feedback we received. The switchboard configuration keeps the features enabled on Nightly, Aurora and Beta. The features are not in release yet but after the merge day we can use switchboard to decide if we want to roll this out or not.

[User impact if declined]: Without that the features will ride the trains to release after the next merge day and we might not have enough time left to make changes based on the feedback.

[Describe test coverage new/current, TreeHerder]: Local testing.

[Risks and why]: Low - This patch just adds the switchboard experiments and falls back to the default behavior for URLs if the user is in no experiment.

[String/UUID change made/needed]: -
Attachment #8751220 - Flags: approval-mozilla-beta?
Attachment #8751220 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/dfb23d172953
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment on attachment 8751220 [details]
MozReview Request: Bug 1271698 - Add Switchboard flags for URL bar changes. r?margaret

Switchboard flags for dynamic control of feature per channel. Aurora48+, Beta47+
Attachment #8751220 - Flags: approval-mozilla-beta?
Attachment #8751220 - Flags: approval-mozilla-beta+
Attachment #8751220 - Flags: approval-mozilla-aurora?
Attachment #8751220 - Flags: approval-mozilla-aurora+
Hitting conflicts uplifting to aurora.
Flags: needinfo?(s.kaspari)
Modified patch for Aurora.
Flags: needinfo?(s.kaspari)
Modified patch for Beta.
Hi Wes, just fyi, the rebased patches are ready to land on m-b. Thanks!
Flags: needinfo?(wkocher)
Verified as fixed in build:
- Aurora 48.0a2 (2016-05-26);
- Nightly 49.0a1 (2016-05-26);
Device: LG G4 (Android 5.1)
You need to log in before you can comment on or make changes to this bug.