1271738 - Port Bug 1223728 to "Import Link" dialog

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Richard Marti (:Paenglab)]

Bug 1223728 changed the autocompletesearch="history" to autocompletesearch="unifiedcomplete". Without this change, the hrefInput won't show autocomplete results.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: urllink.patch

Implement autocompletesearch="unifiedcomplete" on hrefInput in "Insert Link" dialog.

I also added the class padded to hrefInput to make it as tall as the other input fields (this is only visible on Winows. Linux and OS X are not affected because padding changes have no effect on -moz-appearance="textbox").

Sorry about the many whitespace fixes.

Comment 2

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #1)
> I also added the class padded to hrefInput to make it as tall as the other
> input fields
Great. It has always looked terrible.

> Sorry about the many whitespace fixes.
I think they're good ;-)

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8750909 [details] [diff] [review]
urllink.patch

Review of attachment 8750909 [details] [diff] [review]:
-----------------------------------------------------------------

So the only change here is:
-  autocompletesearch="history" timeout="50" maxrows="6"
-  enablehistory="true" class="uri-element"
+  autocompletesearch="unifiedcomplete" timeout="50" maxrows="6"
+  enablehistory="true" class="uri-element padded"

I tested that without the patch there are no auto-complete results, with the patch, there are.

I also checked that this is the correct fix according to bug 1223728, for example:
https://hg.mozilla.org/mozilla-central/rev/44a989cf6c16#l1.13

So: r=jorgk

(Stealing this review since Magnus has a heap of other reviews to get through.)

Comment 4

[Richard Marti (:Paenglab)]

Attachment: urllink.patch

Fixed in comment the reviewer.

Comment 5

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/cf9529c1f245