1271842 - Need async nsIPrompt API

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Justin Dolske [:Dolske]]

The current nsIPrompt APIs are used all over (and in extensions too), but they're all synchronous APIs... Call a prompt, wait for the user to interact, call returns. This has a number of problems -- there's an extra event loop spinning while the prompt is open, and hangs can result when other things spin the event loop (such as another prompt). This can also make converting prompts to tab-modal form difficult -- callers can be in an intermediate state when the tab is closed, and verifying correctness in such cases is tricky and non-obvious.

We should have a version of the nsIPrompt API that's asynchronous, using callbacks or Promises so that callers do not have to block waiting for the prompt to complete.

Note that nsIAuthPrompt2 has asyncPromptAuth(), which is kinda what we want, but it's actually implemented in the prompt code with a normal synchronous prompt.

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1271842 - nsIPromptService: Added async prompt methods. r=johannh!

Depends on D66450

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 1271842 - Updated nsIPromptService documentation. r=johannh!

Depends on D67505

Comment 4

[Emma Zühlcke [:emz]]

Attachment: Bug 1271842 - Updated prompt tests to include async prompting. r=johannh!

Depends on D67506

Comment 5

[Emma Zühlcke [:emz]]

Attachment: Bug 1271842 - GeckoView: Support for promise-based async prompting.

This is the implementation for the newly added async prompt methods in nsIPromptService.
Async prompt methods return a Promise which resolves an nsIPropertyBag with the
prompt result values.

Depends on D69595

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/091a64a38136
nsIPromptService: Added async prompt methods. r=johannh
https://hg.mozilla.org/integration/autoland/rev/7262ae6d42ec
Updated prompt tests to include async prompting. r=johannh

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for mochitest failures on test_prompt.html.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&tochange=b7a400987981a46df5381200e6cb675d702b3c21&fromchange=cdedf7ddec475911cc96e4e88825c91639d249cc&failure_classification_id=2&selectedJob=298672452

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=298673203&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=298672486&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/b7a400987981a46df5381200e6cb675d702b3c21

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b16151863369
nsIPromptService: Added async prompt methods. r=johannh
https://hg.mozilla.org/integration/autoland/rev/bace62107e14
Updated prompt tests to include async prompting. r=johannh

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b16151863369
https://hg.mozilla.org/mozilla-central/rev/bace62107e14

Comment 10

[Emma Zühlcke [:emz]]

Sorry, forgot to mark as 'leave-open'. Still missing a patch (is up for review).