Closed Bug 1271865 Opened 9 years ago Closed 9 years ago

Remove JitFrameIterator::verifyReturnAddressUsingNativeToBytecodeMap

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(1 file)

Remove JitFrameIterator::verifyReturnAddressUsingNativeToBytecodeMap
4.40 KB, patch
djvj
: review+
Details | Diff | Splinter Review
JitFrameIterator::verifyReturnAddressUsingNativeToBytecodeMap() is unused.
Comment on attachment 8751060 [details] [diff] [review] Remove JitFrameIterator::verifyReturnAddressUsingNativeToBytecodeMap Review of attachment 8751060 [details] [diff] [review]: ----------------------------------------------------------------- I'll r+ this, but just note that this is a helpful debug function to have around when chasing issues with the jitcode map. Can you wrap it an #ifdef DEBUG instead? I'll leave the decision to your judgement.
Attachment #8751060 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f940ea93119c2bcaf1010e58b0bec75c99a10c7b Bug 1271865 - Add a comment to JitFrameIterator::verifyReturnAddressUsingNativeToBytecodeMap. r=djvj.
It's already DEBUG-only, so I'll just add a comment explaining that it's useful to keep around.
https://hg.mozilla.org/mozilla-central/rev/f940ea93119c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
See Also: → 1963824
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: