1963824 - Remove debugging function JSJitFrameIter::verifyReturnAddressUsingNativeToBytecodeMap()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Bryan Thrall [:bthrall]]

JSJitFrameIter::verifyReturnAddressUsingNativeToBytecodeMap() might be useful to have around for debugging, but it is likely out of date and is blocking us from removing GC things from JitcodeGlobalEntry (which we believe is causing some crashes during profiling and at shutdown, and holding memory longer than necessary).

Removing this function means we can also remove JitcodeGlobalEntry::callStackAtAddr(JSRuntime* rt, void* ptr, BytecodeLocationVector& results, uint32_t* depth) and all its implementations.

Comment 1

[Nathan Mentze:nmentz]

Attachment: Bug 1963824 - Remove verifyReturnAddressUsingNativeToBytecodeMap from JSJitFrameIter r=bthrall

Comment 2

[Nazım Can Altınova [:canova]]

@bthrall, hey it looks like it's approved. Could we land this patch now?

Comment 3

[Bryan Thrall [:bthrall]]

Unfortunately, it doesn't look like the patch applies to latest main.

:nmentz, could you please rebase the patch?

I can land it as soon as it is rebased.

Comment 4

[Nazım Can Altınova [:canova]]

This bug blocks bug 1969435, so I'll rebase the patch and land it preserving the author. Thanks for working on it!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/42d716f6a366
https://hg.mozilla.org/integration/autoland/rev/c402c7f85448
Remove verifyReturnAddressUsingNativeToBytecodeMap from JSJitFrameIter r=bthrall

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c402c7f85448