Open Bug 1963824 Opened 22 days ago Updated 11 days ago

Remove debugging function JSJitFrameIter::verifyReturnAddressUsingNativeToBytecodeMap()

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

ASSIGNED

People

(Reporter: bthrall, Assigned: nmentz)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

JSJitFrameIter::verifyReturnAddressUsingNativeToBytecodeMap() might be useful to have around for debugging, but it is likely out of date and is blocking us from removing GC things from JitcodeGlobalEntry (which we believe is causing some crashes during profiling and at shutdown, and holding memory longer than necessary).

Removing this function means we can also remove JitcodeGlobalEntry::callStackAtAddr(JSRuntime* rt, void* ptr, BytecodeLocationVector& results, uint32_t* depth) and all its implementations.

Blocks: sm-runtime
Severity: -- → N/A
Priority: -- → P3
Keywords: good-first-bug
Assignee: nobody → natementze+github
Attachment #9486778 - Attachment description: WIP: Bug 1963824 - Remove verifyReturnAddressUsingNativeToBytecodeMap from JSJitFrameIter → Bug 1963824 - Remove verifyReturnAddressUsingNativeToBytecodeMap from JSJitFrameIter r=bthrall
Status: NEW → ASSIGNED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: