1272232 - Remove use of FlushableTaskQueue::Flush() from AppleVDADecoder::Flush()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Similar to bug 1272225.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1272232. Part 1 - move code around so we can extract common code in P2. r=jya.

Review commit: https://reviewboard.mozilla.org/r/52644/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52644/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1272232. Part 2 - extract common code to the parent class. r=jya.

Review commit: https://reviewboard.mozilla.org/r/52646/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52646/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1272232. Part 3 - constify some members and make them private when possible. r=jya.

Review commit: https://reviewboard.mozilla.org/r/52648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52648/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1272232. Part 4 - remove use of FlushableTaskQueue::Flush(). r=jya.

Review commit: https://reviewboard.mozilla.org/r/52650/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52650/

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1272232. Part 5 - remove use of FlushableTaskQueue. r=jya.

Review commit: https://reviewboard.mozilla.org/r/52652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52652/

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8752566 [details]
MozReview Request: Bug 1272232. Part 1 - move code around so we can extract common code in P2. r=jya.

https://reviewboard.mozilla.org/r/52644/#review49838

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8752567 [details]
MozReview Request: Bug 1272232. Part 2 - extract common code to the parent class. r=jya.

https://reviewboard.mozilla.org/r/52646/#review49840

Comment 8

[Jean-Yves Avenard [:jya]]

Comment on attachment 8752568 [details]
MozReview Request: Bug 1272232. Part 3 - constify some members and make them private when possible. r=jya.

https://reviewboard.mozilla.org/r/52648/#review49842

::: dom/media/platforms/apple/AppleVDADecoder.h:91
(Diff revision 1)
> -  // OutputFrame is thread-safe.
> -  nsresult OutputFrame(CVPixelBufferRef aImage,
> -                       AppleFrameRef aFrameRef);
> -
>  protected:
> +  AppleVDADecoder(const VideoInfo& aConfig,

How can you make the constructor private? How would the Apple PDM create it unless you play with friendship.

can't make that protected.

::: dom/media/platforms/apple/AppleVDADecoder.cpp:37
(Diff revision 1)
>  #define LOG(...) MOZ_LOG(GetPDMLog(), mozilla::LogLevel::Debug, (__VA_ARGS__))
>  //#define LOG_MEDIA_SHA1
>  
>  namespace mozilla {
>  
> +static uint32_t ComputeMaxRefFrames(const mozilla::MediaByteBuffer* aExtraData)

WE'RE already in the Mozilla namespace, you can drop it from MediaByteBuffer.

Comment 9

[Jean-Yves Avenard [:jya]]

Comment on attachment 8752569 [details]
MozReview Request: Bug 1272232. Part 4 - remove use of FlushableTaskQueue::Flush(). r=jya.

https://reviewboard.mozilla.org/r/52650/#review49844

Comment 10

[Jean-Yves Avenard [:jya]]

Comment on attachment 8752570 [details]
MozReview Request: Bug 1272232. Part 5 - remove use of FlushableTaskQueue. r=jya.

https://reviewboard.mozilla.org/r/52652/#review49846

Comment 11

[Jean-Yves Avenard [:jya]]

https://reviewboard.mozilla.org/r/52648/#review49842

> How can you make the constructor private? How would the Apple PDM create it unless you play with friendship.
> 
> can't make that protected.

Had forgotten about CreateVDADecoder

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4fdac9c2c14b
https://hg.mozilla.org/integration/mozilla-inbound/rev/64bf09ce3533
https://hg.mozilla.org/integration/mozilla-inbound/rev/f158ef82936c
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7c63a0d98a2
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bb3981b0c70

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4fdac9c2c14b
https://hg.mozilla.org/mozilla-central/rev/64bf09ce3533
https://hg.mozilla.org/mozilla-central/rev/f158ef82936c
https://hg.mozilla.org/mozilla-central/rev/d7c63a0d98a2
https://hg.mozilla.org/mozilla-central/rev/5bb3981b0c70