Closed Bug 1272232 Opened 4 years ago Closed 4 years ago

Remove use of FlushableTaskQueue::Flush() from AppleVDADecoder::Flush()

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(5 files)

Similar to bug 1272225.
Assignee: nobody → jwwang
Blocks: 1270039
Comment on attachment 8752566 [details]
MozReview Request: Bug 1272232. Part 1 - move code around so we can extract common code in P2. r=jya.

https://reviewboard.mozilla.org/r/52644/#review49838
Attachment #8752566 - Flags: review?(jyavenard) → review+
Attachment #8752567 - Flags: review?(jyavenard) → review+
Comment on attachment 8752567 [details]
MozReview Request: Bug 1272232. Part 2 - extract common code to the parent class. r=jya.

https://reviewboard.mozilla.org/r/52646/#review49840
Comment on attachment 8752568 [details]
MozReview Request: Bug 1272232. Part 3 - constify some members and make them private when possible. r=jya.

https://reviewboard.mozilla.org/r/52648/#review49842

::: dom/media/platforms/apple/AppleVDADecoder.h:91
(Diff revision 1)
> -  // OutputFrame is thread-safe.
> -  nsresult OutputFrame(CVPixelBufferRef aImage,
> -                       AppleFrameRef aFrameRef);
> -
>  protected:
> +  AppleVDADecoder(const VideoInfo& aConfig,

How can you make the constructor private? How would the Apple PDM create it unless you play with friendship.

can't make that protected.

::: dom/media/platforms/apple/AppleVDADecoder.cpp:37
(Diff revision 1)
>  #define LOG(...) MOZ_LOG(GetPDMLog(), mozilla::LogLevel::Debug, (__VA_ARGS__))
>  //#define LOG_MEDIA_SHA1
>  
>  namespace mozilla {
>  
> +static uint32_t ComputeMaxRefFrames(const mozilla::MediaByteBuffer* aExtraData)

WE'RE already in the Mozilla namespace, you can drop it from MediaByteBuffer.
Attachment #8752568 - Flags: review?(jyavenard) → review+
Comment on attachment 8752569 [details]
MozReview Request: Bug 1272232. Part 4 - remove use of FlushableTaskQueue::Flush(). r=jya.

https://reviewboard.mozilla.org/r/52650/#review49844
Attachment #8752569 - Flags: review?(jyavenard) → review+
Comment on attachment 8752570 [details]
MozReview Request: Bug 1272232. Part 5 - remove use of FlushableTaskQueue. r=jya.

https://reviewboard.mozilla.org/r/52652/#review49846
Attachment #8752570 - Flags: review?(jyavenard) → review+
https://reviewboard.mozilla.org/r/52648/#review49842

> How can you make the constructor private? How would the Apple PDM create it unless you play with friendship.
> 
> can't make that protected.

Had forgotten about CreateVDADecoder
You need to log in before you can comment on or make changes to this bug.