Marionette driven tests are missing support for MOZ_DISABLE_NONLOCAL_CONNECTIONS
Categories
(Remote Protocol :: Marionette, defect, P3)
Tracking
(firefox99 fixed)
Tracking | Status | |
---|---|---|
firefox99 | --- | fixed |
People
(Reporter: whimboo, Assigned: jdescottes)
References
Details
Attachments
(2 files)
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Reporter | ||
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
Comment 5•7 years ago
|
||
Comment 6•7 years ago
|
||
Reporter | ||
Comment 7•7 years ago
|
||
Comment 8•7 years ago
|
||
Updated•7 years ago
|
Comment 9•7 years ago
|
||
Reporter | ||
Comment 10•7 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 12•3 years ago
|
||
Comment 13•3 years ago
|
||
Comment 14•3 years ago
|
||
bugherder |
Comment 15•3 years ago
|
||
Comment 16•3 years ago
|
||
Backed out for causing Bug 1753649
Failure line 1: FATAL ERROR: Non-local network connections are disabled and a connection attempt to firefox.settings.services.mozilla.com (13.35.122.85) was made.
Failure line 2: PROCESS-CRASH | marionette.py | application crashed [@ mozilla::net::nsSocketTransport::InitiateSocket()]
Assignee | ||
Comment 17•3 years ago
|
||
Thanks! See some explanation & investigation over at Bug 1753649 comment #1 and Bug 1753649 comment #2
Assignee | ||
Comment 18•3 years ago
•
|
||
I reviewed existing call sites for isInAutomation and didn't find anything suspicious so far, so hopefully we can get away with a fix focused on https://searchfox.org/mozilla-central/rev/bb14d901ac16633801b7f4adaa4fb104e6f072e4/services/settings/Utils.jsm#60-72
The remaining question is how should we detect that we are running marionette-based tests.
Few options:
- we could use
MOZ_MARIONETTE
, but this is always set when Marionette is enabled, so it might be incorrect - we can create another env variable, we just need to figure out from where it would make sense. Would geckoinstance be ok? Or should we set it from the same spots where we set
MOZ_DISABLE_NONLOCAL_CONNECTIONS
. - alternatively Utils.jsm could check
MOZ_DISABLE_NONLOCAL_CONNECTIONS
? It's more generic than checking against marionette and makes sense from a code standpoint: if we are in an environment which disables connections, we should not force the settings server
Assignee | ||
Comment 19•3 years ago
|
||
FWIW, the 3rd option seems to fix the issue: https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=Hw9HZ9EpRQ2XnwuAwUS5tg.0&revision=6b384e73a83f6aa12c0b2c71d2bbdcad932fde24
Assignee | ||
Comment 20•3 years ago
|
||
Depends on D137691
On BETA and RELEASE channels, Marionette based tests started crashing due to remote connections.
We are overriding the preference for Firefox settings, but this codepaths hardcodes the URL on BETA and RELEASE channels.
Since we are already detecting test harnesses via Cu.isInAutomation (+ checking an env variable for xpcshell) we could also check for the MOZ_DISABLE_NONLOCAL_CONNECTIONS env variable.
Updated•3 years ago
|
Comment 21•3 years ago
|
||
Comment 22•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/66941397c141
https://hg.mozilla.org/mozilla-central/rev/dce3e334a5d9
Updated•2 years ago
|
Description
•