1757776 - "mach firefox-ui-functional" fails with "TypeError: argument of type 'NoneType' is not iterable"

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Currently the code to set the MOZ_DISABLE_NONLOCAL_CONNECTIONS environment variable expects that test_tags are always set, but this is not the case when just running ./mach firefox-ui-functional:

➜  mach firefox-ui-functional                                                                                                                                                                           $(git_super_status)
Error running mach:

    ['firefox-ui-functional']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file firefox-ui-functional| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: argument of type 'NoneType' is not iterable

  File "/Users/henrik/code/gecko/testing/firefox-ui/mach_commands.py", line 115, in run_firefox_ui_functional
    return run_firefox_ui_test(
  File "/Users/henrik/code/gecko/testing/firefox-ui/mach_commands.py", line 68, in run_firefox_ui_test
    if "test_tags" in kwargs and "remote" not in kwargs.get("test_tags"):

Sentry event ID: 750cc53a4d194be1b069f671ff70d991
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-C to quit

When not specifying a tag with --tag [remote|local] the default applies and tests will get their tag assigned via the manifest file.

Maybe we should get the remaining local tests finally ported to Marionette tests (bug 1573410) and keep the remote ones only in firefox-ui. That way we won't have to make that decision based on test tag.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Will be fixed soon by the upcoming patches on bug 1573410.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Fixed by the refactoring of the firefox-ui harness on bug 1573410.