Adblock Edge add-on is broken

RESOLVED WONTFIX

Status

()

Firefox
Extension Compatibility
RESOLVED WONTFIX
2 years ago
a year ago

People

(Reporter: Vasilica Mihasca, QA [away for an extended period of time - please needinfo addonsqa@softvision.ro], Unassigned)

Tracking

({regression})

Trunk
regression
Points:
---

Firefox Tracking Flags

(firefox46 affected, firefox47 affected, firefox48 affected, firefox49 affected)

Details

(Whiteboard: triaged)

[Note]
This is a follow-up bug for Bug 1257847

[Affected versions]:
Firefox 49.0a1 (2016-05-12)
Firefox 48.0a2 (2016-05-12)
Firefox 47.0b4 (20160509171155)

[Affected platforms]:
Windows 10 64-bit
Ubuntu 14.04 32-bit
Mac OS X 10.9.5

[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Install the following add-on:  https://addons.mozilla.org/en-US/firefox/addon/adblock-edge/?src=ss
3.Go to about:addons -> Extensions
4.Click on Adblock Edge “Options” button.
5.Select the "Show in toolbar" checkbox.

[Expected results]:
The Adblock Edge icon is successfully displayed in toolbar.

[Actual results]:
- The icon is not displayed.
- The check mark is erased while refreshing the page.
- “Filter preferences…” button does nothing.

[Regression Range]:
Last good revision: 2afd5728f13aebe9c2daa85dd831b4e4ac2ac121
First bad revision: 69a9775dc5c921d180a4fef1d2e7812610e70d56
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2afd5728f13aebe9c2daa85dd831b4e4ac2ac121&tochange=69a9775dc5c921d180a4fef1d2e7812610e70d56
Which bug do you think that caused this regression?
Flags: needinfo?(jwalden+bmo)
One's just fixing our own code internally, so it's not that.  Ergo, bug 1146136.

Note that that change was a spec issue we had to fix, and it landed a very long time ago with basically no issues, so it's not going to be reverted or backed out.  The addon should be updated according to the discussion of the change at <http://whereswalden.com/2015/06/20/new-changes-to-make-spidermonkeys-and-firefoxs-parsing-of-destructuring-patterns-more-spec-compliant/>.
Flags: needinfo?(jwalden+bmo)
Jorgev, could someone reach out to the addon author based on comment 2 please?
Flags: needinfo?(jorge)
Whiteboard: triaged
I sent a message to the developer. However, the add-on hasn't been updated for a while and the description says it is abandoned, so I don't know if it will be updated.
Component: Add-ons Manager → Extension Compatibility
Flags: needinfo?(jorge)
Product: Toolkit → Firefox
Marking as won't fix then. Thanks Jorge.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.