1272562 - MOZ_DIAGNOSTIC_ASSERT failure in mozilla::MediaFormatReader::Seek

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Nicholas Nethercote [inactive]]

This bug was filed from the Socorro interface and is 
report bp-275bf379-f20e-4ee4-9e33-5328e2160512.
=============================================================

This started showing up in Nightly 20160512030253. This assertion is failing:

  MOZ_DIAGNOSTIC_ASSERT(mSeekPromise.IsEmpty());

On Windows it's #5 topcrash for that build, on Mac it's #2, on Linux it's #1. YouTube is present in several of the crash reports.

jya, can you please take a look?

Comment 1

[u480271]

Attachment: MozReview Request: Bug 1272562 - Don't check audio asserts when seeking video. r?jya

Really need to reset any outstanding mAudio promise when resetting MFR,
even in the case of just seeking the video.

Review commit: https://reviewboard.mozilla.org/r/52411/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52411/

Comment 2

[u480271]

Comment on attachment 8752067 [details]
MozReview Request: Bug 1272562 - Don't check audio asserts when seeking video. r?jya

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52411/diff/1-2/

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8752067 [details]
MozReview Request: Bug 1272562 - Don't check audio asserts when seeking video. r?jya

https://reviewboard.mozilla.org/r/52411/#review49329

Comment 4

[Jean-Yves Avenard [:jya]]

(In reply to Dan Glastonbury :kamidphish from comment #1)
> Created attachment 8752067 [details]
> MozReview Request: Bug 1272562 - Don't check audio asserts when seeking
> video. r?jya
> 
> Really need to reset any outstanding mAudio promise when resetting MFR,
> even in the case of just seeking the video.

Why is that?

This sounds wrong to me. 

> 
> Review commit: https://reviewboard.mozilla.org/r/52411/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/52411/

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8752067 [details]
MozReview Request: Bug 1272562 - Don't check audio asserts when seeking video. r?jya

https://reviewboard.mozilla.org/r/52411/#review49371

::: dom/media/MediaFormatReader.cpp
(Diff revisions 1 - 2)
>        mVideo.RejectPromise(CANCELED, __func__);
>      }
>    }
>  
> -  if (HasAudio()) {
> +  if (HasAudio() && aQueues == AUDIO_VIDEO) {
> -    if (aQueues == AUDIO_VIDEO) {

Oh i see.. I should have spotted this in the other bug.

sorry for that.

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8752067 [details]
MozReview Request: Bug 1272562 - Don't check audio asserts when seeking video. r?jya

https://reviewboard.mozilla.org/r/52411/#review49403

i thought i had r+ this

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b941e2c4e454

Comment 8

[ovidiu boca[:Ovidiu]]

User Agent 	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID 	20160512030253

Nightly 49 crashed for me also with this signature when watching an amazon video using widevine plugin. 

Crash ID:
https://crash-stats.mozilla.com/report/index/1c643ef2-c26a-410f-a764-3870c2160513

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b941e2c4e454

Comment 10

[Nicholas Nethercote [inactive]]

Thank you for the fast fix.

Comment 11

[Nicholas Nethercote [inactive]]

We had 21 of these crashes on Windows in Nightly 20160513030539 and zero in Nightly 20160514030209.

Comment 12

[Nicholas Nethercote [inactive]]

I've moved the [@ mozilla::MediaFormatReader::RequestAudioData] crashes into bug 1273018.