1273018 - Crash in mozilla::MediaFormatReader::UpdateReceivedNewData

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Nicholas Nethercote [inactive]]

This bug was filed from the Socorro interface and is 
report bp-409af35a-bd13-445c-acf8-199462160515.
=============================================================

Three of these crashes in Nightly 20160514030209 on Windows. jya says it's similar to bug 1272562.

Comment 1

[Nicholas Nethercote [inactive]]

Dan, we also have related crashes here:

https://crash-stats.mozilla.com/signature/?build_id=20160514030209&product=Firefox&release_channel=nightly&platform=Windows&date=%3E%3D2016-05-14&signature=mozilla%3A%3AMediaFormatReader%3A%3ARequestAudioData&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&page=1

Please fix those at the same time.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1273018: P1. Rename some members. r?kamidphish

MediaFormatReader::mOriginalSeekTarget now has different use and the name was no longer reflective of the actual usage.

Review commit: https://reviewboard.mozilla.org/r/52740/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52740/

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1273018: P2. Don't reject audio waiting promise when performing a video only seek. r?kamidphish

Review commit: https://reviewboard.mozilla.org/r/52742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52742/

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1273018: P3. Adjust range of audio assertions. r?kamidphish

With the new video-only seek type, we need to ignore the current audio decoding state whenever video-only seeking is in progress.

Review commit: https://reviewboard.mozilla.org/r/52744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52744/

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8752707 [details]
MozReview Request: Bug 1273018: P1. Rename some members. r?kamidphish

https://reviewboard.mozilla.org/r/52740/#review49916

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8752708 [details]
MozReview Request: Bug 1273018: P2. Don't reject audio waiting promise when performing a video only seek. r?kamidphish

https://reviewboard.mozilla.org/r/52742/#review49920

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8752709 [details]
MozReview Request: Bug 1273018: P3. Adjust range of audio assertions. r?kamidphish

https://reviewboard.mozilla.org/r/52744/#review49926

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d910e79d6aa7
https://hg.mozilla.org/integration/mozilla-inbound/rev/b523bf012a7d
https://hg.mozilla.org/integration/mozilla-inbound/rev/7211d10acecc

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d910e79d6aa7
https://hg.mozilla.org/mozilla-central/rev/b523bf012a7d
https://hg.mozilla.org/mozilla-central/rev/7211d10acecc