1272662 - Enable MOZ_PLACES following the move to moz.configure

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[aleth [:aleth]]

MOZ_PLACES was moved in https://hg.mozilla.org/mozilla-central/rev/82e8c5f0da49.

Comment 1

[aleth [:aleth]]

Attachment: Enable MOZ_PLACES for mail/

Comment 2

[aleth [:aleth]]

Attachment: Enable MOZ_PLACES for suite/

Comment 3

[aleth [:aleth]]

Attachment: Enable MOZ_PLACES for im/

Come to think of it, does IB even need places?

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 8752199 [details] [diff] [review]
Enable MOZ_PLACES for mail/

Review of attachment 8752199 [details] [diff] [review]:
-----------------------------------------------------------------

Thx, does this fix the some of the autocomplete test failures perhaps?

Comment 5

[aleth [:aleth]]

(In reply to Magnus Melin from comment #4)
> Thx, does this fix the some of the autocomplete test failures perhaps?

No, without this, you don't even get past packaging.

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8752201 [details] [diff] [review]
Enable MOZ_PLACES for im/

Instantbird doesn't use Places, but I'm not sure toolkit/ builds fine without Places.

Comment 7

[aleth [:aleth]]

(In reply to Florian Quèze [:florian] [:flo] from comment #6)
> Instantbird doesn't use Places, but I'm not sure toolkit/ builds fine
> without Places.

It's intentional that the new default is false (see bug 1257326 last comment), so it should. So let's try it and do without this patch for now. I suppose if it works we should add a bunch of files to removed-files.in? (Not sure if there's a quick way to generate a complete list.)

Comment 8

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/5449a5ce585f8be3810c6a1f16fae19c73ffe3c3
Bug 1272662 - Enable MOZ_PLACES for mail/. r=mkmelin

Comment 9

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #7)
> It's intentional that the new default is false (see bug 1257326 last
> comment), so it should. So let's try it and do without this patch for now. I
> suppose if it works we should add a bunch of files to removed-files.in? (Not
> sure if there's a quick way to generate a complete list.)

Ah, the quick way is probably to see which files are missing when packaging is attempted ;)

Comment 10

[Frank-Rainer Grahl (:frg)]

Attachment: 1272662-ratty.patch

Ratty had a wip patch ready for suite yesterday but it got late. Seamonkey needs additional fixes for sync variables which also were moved in bug 1257326. I fixed it up and it seems to work now.

Comment 11

[aleth [:aleth]]

Attachment: Stop shipping Places for IB

Looks like it built OK. This hopefully removes the files that are no longer needed.

Comment 12

[aleth [:aleth]]

Attachment: Stop shipping Places for IB

Should have read all of that documentation I copied ;)

Comment 13

[Philip Chee]

Comment on attachment 8752470 [details] [diff] [review]
1272662-ratty.patch

rs=me thanks! a=bustage fix in case of CLOSED TREE

Comment 14

[Philip Chee]

(In reply to Frank-Rainer Grahl from comment #10)
> Created attachment 8752470 [details] [diff] [review]
> 1272662-ratty.patch
> 
> Ratty had a wip patch ready for suite yesterday but it got late. Seamonkey
> needs additional fixes for sync variables which also were moved in bug
> 1257326. I fixed it up and it seems to work now.

This patch subsumes the patch in attachment 8752200 [details] [diff] [review] (Comment 2). Please go ahead and land this.

Comment 15

[Philip Chee]

Comment on attachment 8752200 [details] [diff] [review]
Enable MOZ_PLACES for suite/

The patch in attachment 8752470 [details] [diff] [review] supersedes this but thank you.

Comment 16

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/dfe4a9e07becca7cf685a9443ed2ddc337c99619
Bug 1272662 - Stop shipping Places for IB. r=florian

Comment 17

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8752200 [details] [diff] [review]
Enable MOZ_PLACES for suite/

Here are the commit details for the complete suite patch

Initial patch:

https://hg.mozilla.org/comm-central/rev/ffe919976f1b

Backed out forgot to put the new bug # in:

https://hg.mozilla.org/comm-central/rev/001cac7a024e

and finally:

https://hg.mozilla.org/comm-central/rev/dcca3e63825f

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/36f25cc57854
Enable MOZ_PLACES for im/. r=clokep