Move MOZ_ANDROID_HISTORY to Python configure

RESOLVED FIXED in Firefox 49

Status

Firefox Build System
General
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: Chris Manchester (mostly offline July 16-20), Assigned: Chris Manchester (mostly offline July 16-20))

Tracking

(Blocks: 1 bug)

unspecified
mozilla49
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 8752366 [details]
MozReview Request: Bug 1272714 - Move MOZ_ANDROID_HISTORY to Python configure. r=glandium

Review commit: https://reviewboard.mozilla.org/r/52561/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52561/
Attachment #8752366 - Flags: review?(mh+mozilla)
Attachment #8752366 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8752366 [details]
MozReview Request: Bug 1272714 - Move MOZ_ANDROID_HISTORY to Python configure. r=glandium

https://reviewboard.mozilla.org/r/52561/#review49884

::: toolkit/moz.configure:421
(Diff revision 1)
> +@depends('MOZ_PLACES', 'MOZ_ANDROID_HISTORY')
> +def check_places_and_android_history(places, android_history):
> +    if places and android_history:
> +        die('Cannot use MOZ_ANDROID_HISTORY alongside MOZ_PLACES.')

It /might/ be nice to add a util function like the following for this:

@template
def conflict(a, b):
    @depends(a, b)
    def conflict_check(value_a, value_b):
        if value_a and value_b:
            die('Cannot use %s alongside %s', a, b)

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0852b1d540bf
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.