1272714 - Move MOZ_ANDROID_HISTORY to Python configure

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1272714 - Move MOZ_ANDROID_HISTORY to Python configure. r=glandium

Review commit: https://reviewboard.mozilla.org/r/52561/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52561/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8752366 [details]
MozReview Request: Bug 1272714 - Move MOZ_ANDROID_HISTORY to Python configure. r=glandium

https://reviewboard.mozilla.org/r/52561/#review49884

::: toolkit/moz.configure:421
(Diff revision 1)
> +@depends('MOZ_PLACES', 'MOZ_ANDROID_HISTORY')
> +def check_places_and_android_history(places, android_history):
> +    if places and android_history:
> +        die('Cannot use MOZ_ANDROID_HISTORY alongside MOZ_PLACES.')

It /might/ be nice to add a util function like the following for this:

@template
def conflict(a, b):
    @depends(a, b)
    def conflict_check(value_a, value_b):
        if value_a and value_b:
            die('Cannot use %s alongside %s', a, b)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0852b1d540bf

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0852b1d540bf