1272723 - Disable b2g automation in buildbot

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Chris AtLee [:catlee]]

We can stop all builds/tests on all branches.

Comment 1

[Chris AtLee [:catlee]]

Attachment: MozReview Request: Bug 1272723 - Remove b2g r=nthomas

Review commit: https://reviewboard.mozilla.org/r/52533/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52533/

Comment 2

[Chris AtLee [:catlee]]

Attachment: MozReview Request: Bug 1272723 - Remove b2g r=nthomas

Review commit: https://reviewboard.mozilla.org/r/52541/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52541/

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8752345 [details]
MozReview Request: Bug 1272723 - Remove b2g r=nthomas

https://reviewboard.mozilla.org/r/52541/#review49616

lgtm

::: common.py:98
(Diff revision 1)
>          'armv6': 'a6',
>          'armv7a': 'a7',
>          'system': 'sys',
> -        'b2g37': 'b37',
> -        'b2g44': 'b44',
>          'v2_5': '25',

v2_5 can go too.

::: common.py:115
(Diff revision 1)
>          'hamachi': 'ham',
>          'wasabi': 'wsb',
>          'graphics': 'gfx',
>          'flame': 'flm',
>          'dolphin': 'dph',
>          'nexus-5': 'n5',

emulator, hamachi, wasabi, flame, dolphin, and nexus-5 can be removed too.

::: misc.py:1464
(Diff revision 1)
> -                    'gaiaL10nRoot': config.get('gaia_l10n_root'),
>                      'mozharness_repo_cache': mozharness_repo_cache,
>                      'tools_repo_cache': pf.get('tools_repo_cache'),
>                      'mozharnessTag': config.get('mozharness_tag'),
>                      'geckoL10nRoot': config.get('gecko_l10n_root'),
>                      'geckoLanguagesFile': pf.get('gecko_languages_file'),

gecko_l10n_root and gecko_languages_file appear to only be defined in in b2g/ in gecko.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8752343 [details]
MozReview Request: Bug 1272723 - Remove b2g r=nthomas

https://reviewboard.mozilla.org/r/52533/#review49620

So long B2G.

::: mozilla/passwords.py.template:8
(Diff revision 1)
>  #PULSE_PASSWORD='public'
>  #PULSE_EXCHANGE='exchange/build/test'
>  
>  secrets = {
>      'nightly-signing': [
> -        ('signing.build.mozilla.org:8080', 'user', 'password', ('gpg', 'sha2signcode', 'osslsigncode', 'signcode', 'mar', 'jar', 'b2gmar')),
> +        ('signing.build.mozilla.org:8080', 'user', 'password', ('gpg', 'sha2signcode', 'osslsigncode', 'signcode', 'mar', 'jar')),

Some signing server cleanup to follow ?

::: setup-master.py:215
(Diff revision 1)
>              renames=[('BuildSlaves.py.template', 'BuildSlaves.py'),
>                       ('passwords.py.template', 'passwords.py')],
>              local_links=[(environment_config, 'localconfig.py'),
>                           ('thunderbird_' + environment_config,
>                            'thunderbird_localconfig.py'),
> -                         ('b2g_' + environment_config, 'b2g_localconfig.py')],
> +                         ],

Bonus points for cleaning up broken symlinks on the buildbot masters.

Comment 5

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/f373116efc7d

Comment 6

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/f373116efc7d

Comment 7

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/14de2833fc34

Comment 8

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/f373116efc7d

Comment 9

[Chris AtLee [:catlee]]

I deleted broken symlinks with this ansible command:

ansible -u cltbld -i master-inventory.py all -m shell -a 'find /builds/buildbot -type l -! -exec test -e {} \; -delete'

We still had some dangling symlinks for esr31!

Comment 10

[Chris AtLee [:catlee]]

Attachment: MozReview Request: Bug 1272723 - Remove b2g r=nthomas

Review commit: https://reviewboard.mozilla.org/r/52970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52970/

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8753057 [details]
MozReview Request: Bug 1272723 - Remove b2g r=nthomas

https://reviewboard.mozilla.org/r/52970/#review49828

::: modules/buildmaster/templates/BuildSlaves-tests.py.erb:32
(Diff revision 1)
>      'win8': """<%=scope.function_secret(["win_tests_password"])%>""",
>      'win8_64': """<%=scope.function_secret(["win_tests_password"])%>""",
>      'win10': """<%=scope.function_secret(["win_tests_password"])%>""",
>      'win10_64': """<%=scope.function_secret(["win_tests_password"])%>""",
>      'win64_vm': """<%=scope.function_secret(["win_tests_password"])%>""",
>      'vm_android_2_3': """<%=scope.function_secret(["android_tests_password"])%>""",

I think this one can go too, only found in this file.

::: modules/runner/files/post_flight.py:55
(Diff revision 1)
>      '''
>      A list of build name expressions which will coerce a halt, names are
>      retrieved from buildapi via get_recent_builds().
>      '''
> -    # reboot after android, b2g emulator, reftest, or mochitest jobs
> +    # reboot after android, emulator, reftest, or mochitest jobs
>      return ['.*android.*', '.*emulator.*', '.*mochi.*', '.*reftest.*']

I don't see any builder names containing 'emulator' in allthethings.json. 

Also wondering what '.*android.*' is supposed to match (bug 1122601 is no help). Currently it's picking up release automation build & repacks, plus 8 tests like 'Android 4.2 x86 Emulator fx-team opt test androidx86-set-4' (one per branch).

Comment 12

[Chris AtLee [:catlee]]

Comment on attachment 8753057 [details]
MozReview Request: Bug 1272723 - Remove b2g r=nthomas

Removed vm_android_2_3, but left the blacklist in runner alone. I don't understand yet where those values were coming from.

Comment 13

[Chris AtLee [:catlee]]

Attachment: MozReview Request: Bug 1272723 - Remove b2g r=nthomas

Review commit: https://reviewboard.mozilla.org/r/53264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53264/

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8753433 [details]
MozReview Request: Bug 1272723 - Remove b2g r=nthomas

https://reviewboard.mozilla.org/r/53264/#review50124

r+ with a bit more tidying up for trychooser.

::: trychooser/index.html:86
(Diff revision 1)
>                  <label><input type="checkbox" name="platform" value="linux64-shell-haz" class="nondefault">shell rooting analysis</label>
>                  <span id="test_linux64-shell-haz" class="test_queue">N/A</span>
>                  <span id="build_linux64-shell-haz" class="build_queue">N/A</span>
>              </li>
>              <li>
>                  <label><input type="checkbox" name="platform" value="linux64-mulet">linux64-mulet</label>

Looks like mulet builders are all gone in allthethings.json, as are graphene and horizon.

Also getTryLoads() in trychooser/tryload.js should be updated to avoid console messages like
Element 'test_macosx64_gecko' not found. Skipping.

Comment 15

[Chris AtLee [:catlee]]

Attachment: MozReview Request: address review comments

Review commit: https://reviewboard.mozilla.org/r/53346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53346/

Comment 16

[Chris AtLee [:catlee]]

Attachment: MozReview Request: remove more mulet references

Review commit: https://reviewboard.mozilla.org/r/53348/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53348/

Comment 17

[Chris AtLee [:catlee]]

https://hg.mozilla.org/build/tools/rev/28780b668da9ecd2b78c1a3dd82ed9fa8dedf7e4
Bug 1272723 - Remove b2g r=nthomas

Comment 18

[Chris AtLee [:catlee]]

deployed trychooser changes

Comment 19

[Jordan Lund (:jlund)]

https://hg.mozilla.org/build/tools/rev/da0a6fe5ebc53e75b0b135c5f80c397ad7991393
Bug 1272723 - Disable b2g automation, readd master_dir on bm103 after typo, r=rail