1272882 - Port bug 925101 - Remove legacy signons.txt files

Status: RESOLVED FIXED

(Thunderbird :: Migration, enhancement)

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: check in migration, v1

Tested by copying a signons3.txt from my default profile into a test profile and starting that with a patched Thunderbird version.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: don't mention file name in code comments, v1

Prevent confusion by updating the code comments which mentioned "signons.txt".

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 8752494 [details] [diff] [review]
check in migration, v1

Review of attachment 8752494 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thx! r=mkmelin

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 8752498 [details] [diff] [review]
don't mention file name in code comments, v1

Review of attachment 8752498 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin if you adjust the texts not to lose the "signons" from the comments and such, for the case below and other similar ones

::: mailnews/compose/test/unit/test_bug155172.js
@@ +36,5 @@
>    registerAlertTestUtils();
>  
>    function createHandler(d) {
>      var handler = new SMTP_RFC2821_handler(d);
> +    // Username needs to match the login information stored in the file.

This begs the question, which file?
Maybe better to write ... "in the signons json file"
(I'm not sure which of the signons-<something>.json files each of this comments refers to.)

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Pushed:
code: https://hg.mozilla.org/comm-central/rev/d52a8f883be3
code comments updated: https://hg.mozilla.org/comm-central/rev/5dc0737191e9