Closed Bug 1272882 Opened 5 years ago Closed 5 years ago

Port bug 925101 - Remove legacy signons.txt files

Categories

(Thunderbird :: Migration, enhancement)

49 Branch
enhancement
Not set
normal

Tracking

(thunderbird49 fixed)

RESOLVED FIXED
Tracking Status
thunderbird49 --- fixed

People

(Reporter: aryx, Assigned: aryx)

References

Details

Attachments

(2 files)

No description provided.
Tested by copying a signons3.txt from my default profile into a test profile and starting that with a patched Thunderbird version.
Attachment #8752494 - Flags: review?(mkmelin+mozilla)
Prevent confusion by updating the code comments which mentioned "signons.txt".
Attachment #8752498 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8752494 [details] [diff] [review]
check in migration, v1

Review of attachment 8752494 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thx! r=mkmelin
Attachment #8752494 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 8752498 [details] [diff] [review]
don't mention file name in code comments, v1

Review of attachment 8752498 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin if you adjust the texts not to lose the "signons" from the comments and such, for the case below and other similar ones

::: mailnews/compose/test/unit/test_bug155172.js
@@ +36,5 @@
>    registerAlertTestUtils();
>  
>    function createHandler(d) {
>      var handler = new SMTP_RFC2821_handler(d);
> +    // Username needs to match the login information stored in the file.

This begs the question, which file?
Maybe better to write ... "in the signons json file"
(I'm not sure which of the signons-<something>.json files each of this comments refers to.)
Attachment #8752498 - Flags: review?(mkmelin+mozilla) → review+
Pushed:
code: https://hg.mozilla.org/comm-central/rev/d52a8f883be3
code comments updated: https://hg.mozilla.org/comm-central/rev/5dc0737191e9
Severity: normal → enhancement
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Version: unspecified → 49 Branch
You need to log in before you can comment on or make changes to this bug.