1273112 - A new password is saved for a login form although the Confirm Password Change dialog was cancelled

Status: NEW

(Toolkit :: Password Manager, defect, P3)

Description

[Comorasu Cristian]

[Affected versions]:
47.0b4-build1 (20160509171155)
48.0a2-build2 (20160511004106)
49.0a1-build1 (20160508030214)


[Affected platforms]:
Windows 10 x64
Ubuntu 14.04 LTS x64
MAC OS X 10.11 

[Steps to reproduce]:
1.Open Firefox with a profile that contains minimum 2 saved accounts via www.twitter.com (i.e account a and account b).
2.Log in with account a and change it's password(profile and settings>password).
3.Type the current password , new password and verify the new password.
4.Click "Save changes".
5.From the context menu select "Cancel" ( http://imgur.com/gqM05ZN ) .
6.Re-log with account a using account a auto fill (http://imgur.com/3fFSLUI ).
7.Complete the new password and enter (  http://imgur.com/Hpwjefb ).

[Expected result]:
The password saving process is canceled.

[Actual result]:
The password is changed. 

[Regression range]:
This bug is not a regression as I've managed to reproduce the same behavior on Fx 9.0a1 (2011-09-27).

Comment 1

[Matthew N. [:MattN]]

(In reply to Comorasu Cristian from comment #0)

5.From the context menu select "Cancel" ( http://imgur.com/gqM05ZN ) .

I don't understand this step… there is no "Cancel" option in the context menu. I didn't try to reproduce this though.

Comment 2

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Hello Matthew, since the issue was logged, the happy flow changed. I will return as soon as possible with new STR's.

Comment 3

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

(In reply to Comorasu Cristian from comment #0)

5.From the context menu select "Cancel" ( http://imgur.com/gqM05ZN ) .

I don't understand this step… there is no "Cancel" option in the context menu. I didn't try to reproduce this though.

Hello Matthew,

I can still reproduce this issue. The option to cancel is displayed once a websites has two accounts saved, and the user attempts to change the password for one of the accounts from the website.

Comment 4

[Sam Foster [:sfoster] (he/him)]

(In reply to Cristian Comorasu, QA [:ccomorasu], Release Desktop QA from comment #3)

I can still reproduce this issue. The option to cancel is displayed once a websites has two accounts saved, and the user attempts to change the password for one of the accounts from the website.

I'm not able to reproduce this as we don't currently open any doorhanger or the update passwords/multiple logins prompt (promptToChangePasswordWithUsernames) on twitter's change password form. I've filed bug 1618663 for that. Are you able to reproduce this on any other sites?

Comment 5

[Timea Cernea [:tbabos][inactive]]

Stealing this from Cristi as I had looked into Bug 1618663.
I can't reproduce this issue on the latest Nightly mainly due to the issue submitted by Sam. If that will be fixed I will come back to this one but for now I can't toggle the doorhanger nor the password modal mentioned by Cristi.

Comment 6

[Sam Foster [:sfoster] (he/him)]

(In reply to Timea Cernea [:tbabos] from comment #5)

I can't reproduce this issue on the latest Nightly mainly due to the issue submitted by Sam. If that will be fixed I will come back to this one but for now I can't toggle the doorhanger nor the password modal mentioned by Cristi.

Have you seen this on any other sites Timea? The symptoms described are worrying but we don't have a way to reproduce currently?

Comment 7

[Timea Cernea [:tbabos][inactive]]

Tried on reddit.com, the new password is not saved if the Password Change dialog is canceled. Attached recordings for reference... could be site issue? I will look out for other sites in the meantime.

Comment 8

[Timea Cernea [:tbabos][inactive]]

Attachment: Reddit Change Password

Comment 9

[Sam Foster [:sfoster] (he/him)]

(In reply to Timea Cernea [:tbabos] from comment #7)

Tried on reddit.com, the new password is not saved if the Password Change dialog is canceled. Attached recordings for reference... could be site issue? I will look out for other sites in the meantime.

If you do find a way to reproduce this, please attach the debug logs.