1154763 - Convert modal password change dialog for an unknown username to a capture doorhanger with a dropdown

Status: NEW

(Toolkit :: Password Manager, defect, P3)

Description

[Benjamin Smedberg]

STR:

Go to mozilla.okta.com
Password is remembered, and I don't change it
Choose "sign in"

Expected:
I get signed in without any notifications

Actual:
I get a modal dialog box: "Confirm Password Change" "Please confim which user you are changing the password for: [e-mail] | [e-mail] : [Ok] [Cancel]

This shouldn't be a modal dialog box to begin with, but it also shouldn't show up when I didn't actually change the password, *and* there's no way to tell Firefox that I don't care about the difference in case or to delete one of the remembered accounts.

Comment 1

[Matthew N. [:MattN]]

The okta prompting issue is bug 1155390 but is normally a doorhanger unless you have more than one saved login for the site (like you do). You're seeing the mythical prompt that is almost never seen. In all my years of working on password manager I've never seen this in the wild because it requires a login form with multiple non-empty password fields submitted, no username field detected (bug 1145754 will fix that for Okta), and multiple saved logins for that site.

I agree we should convert this to a doorhanger and that's already specified at https://www.lucidchart.com/documents/edit/87ab1cc8-e708-49d3-8b91-6e2e6da346fb/1 in the "multiple saved usernames" case so I will morph this bug to cover that remaining issue.

Comment 2

[Tim Nguyen :ntim]

Attachment: Testcase

Comment 3

[Tim Nguyen :ntim]

STR:

• Go to https://bugzilla.mozilla.org/attachment.cgi?id=9076941
  (Alternatively, there's also https://nt1m.github.io/playground/multiple-password-fields-without-username.html )
• Save 2 different passwords that have 2 different usernames associated to them
• Try to save a 3rd different password (make sure that both password fields have a different value)

AR: Get the modal prompt

ER: Get a doorhanger with a dropdown or any newer UX

Comment 4

[Matthew N. [:MattN]]

Now that bug 1641413 is fixed I think we can remove this dialog and probably remove promptToChangePasswordWithUsernames altogether.