1273222 - Stop building and deploying the DOM Inspector extension with SeaMonkey 2.57

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, task)

Description

[Adrian Kalla [:adriank]]

With bug 1223341 fixed we have the Fx developer tools working in SeaMonkey. Since the DevTools already include a dom inspector, there is no need to duplicate the functionality in the default SeaMonkey installation and thus it is s time to stop building and deploying DOMi with Sm 2.45 and newer.

If someone still needs or depends on the old DOM Inspector, it is still available on AMO and can be installed from there.

Comment 1

[rexyrexy2]

I don't really see a reason to remove it though..?  Having it as part of SeaMonkey gives the advantage that it is tested, updated, and Localized as part of SeaMonkey. Also, the DOM capabilities of the devtools are not as great, and the dev tools cannot inspect chrome/XUL as well. I find the dev tools extremely useful, but they are not a replacement for the DOM inspector. (or its UI) Plus, the DOM inspector has been a part of the suite for a while.

Comment 2

[rsx11m]

We are also keeping the old Error Console around as part of SeaMonkey despite having "something" for that in devtools as well. Thus, I'd agree with comment #1 that keeping it around as a complementary tool shouldn't hurt as long as it is sufficiently maintained.

Comment 3

[Frank-Rainer Grahl (:frg)]

As stated on todays status meeting. Maybe like debugQA it should be bundled by default only in a1 and a2 builds. For beta and release builds an additonal enable statement could also be created to build it locally. This would also be useful for debugQA.

build config for debugQA:

>> # This should match /suite/installer/moz.build.
>> if 'pre' in CONFIG['MOZ_APP_VERSION'] or 'a' in CONFIG['MOZ_APP_VERSION']:
>>    DIRS += ['debugQA']

Evaluation could probably be moved to confvars.sh and set a single pref like DOMI_ENABLED=1. 

As long as the extension is used and not completely broken it should probably be kept. The problem with devtools is also that we have no control over it and it might be broken anytime because its really Firefox centric imho. But I also do not see much value in bundling it with release builds. 99,99% of current users would probably never need it and the rest can get it elsewhere or compile it itself.

Comment 4

[rsx11m]

(In reply to Frank-Rainer Grahl from comment #3)
> As stated on todays status meeting. Maybe like debugQA it should be bundled
> by default only in a1 and a2 builds. For beta and release builds an
> additonal enable statement could also be created to build it locally.

If that's done, we'll have to make sure that there is always the matching DOMi version on AMO for release builds, for those users who want to continue using it.

Comment 5

[Jonathan Kamens]

>With bug 1223341 fixed we have the Fx developer tools working in SeaMonkey.

But not in the Mail and Newsgroups window, apparently? So maybe we need to fix that before we stop supporting DOM Inspector?

Comment 6

[rsx11m]

Current releases don't come with DOMi and ChatZilla bundled anymore, but that's due to a build issue with localizations, thus not intentional. DOMi is still available as an AMO extension, at least for now, depending on "real" extensions still supported by AMO (and eventually the core code).

Comment 7

[Jonathan Kamens]

I know this isn't completely on-topic for this bug, but given that it relates to installing and using DOM Inspector with SeaMonkey, and I'm having a problem with that, I'm hoping somebody can help me...

I have a version of DOM Inspector labeled "2.0.17pre" installed in SeaMonkey.

I don't know where I got it from, and I can't find it anywhere. I don't, for example, see a development channel for DOM Inspector for AMO.

I found a bug in DOM Inspector with SeaMonkey that I would like to report, but before reporting it I would like to check if it's still a bug in the current version. But the latest version I can find online is the 2.0.16 signed version on AMO.

Is there somewhere else I should be looking to find the current development release of DOM Inspector, whether that's "2.0.17pre" or something newer than that?

Comment 8

[Tony Mechelynck [:tonymec]]

(In reply to Jonathan Kamens from comment #7)
> I know this isn't completely on-topic for this bug, but given that it
> relates to installing and using DOM Inspector with SeaMonkey, and I'm having
> a problem with that, I'm hoping somebody can help me...
> 
> I have a version of DOM Inspector labeled "2.0.17pre" installed in SeaMonkey.
> 
> I don't know where I got it from, and I can't find it anywhere. I don't, for
> example, see a development channel for DOM Inspector for AMO.
> 
> I found a bug in DOM Inspector with SeaMonkey that I would like to report,
> but before reporting it I would like to check if it's still a bug in the
> current version. But the latest version I can find online is the 2.0.16
> signed version on AMO.
> 
> Is there somewhere else I should be looking to find the current development
> release of DOM Inspector, whether that's "2.0.17pre" or something newer than
> that?

https://hg.mozilla.org/dom-inspector/

That's a Mercurial repository, and the "default" branch of that repo is the bleeding-edge latest development version of DOM Inspector if there is one.

Comment 9

[Ian Neal]

(In reply to Jonathan Kamens from comment #7)
> I know this isn't completely on-topic for this bug, but given that it
> relates to installing and using DOM Inspector with SeaMonkey, and I'm having
> a problem with that, I'm hoping somebody can help me...
> 
> I have a version of DOM Inspector labeled "2.0.17pre" installed in SeaMonkey.
> 
> I don't know where I got it from, and I can't find it anywhere. I don't, for
> example, see a development channel for DOM Inspector for AMO.
> 
> I found a bug in DOM Inspector with SeaMonkey that I would like to report,
> but before reporting it I would like to check if it's still a bug in the
> current version. But the latest version I can find online is the 2.0.16
> signed version on AMO.
> 
> Is there somewhere else I should be looking to find the current development
> release of DOM Inspector, whether that's "2.0.17pre" or something newer than
> that?

As per release notes:
DOM Inspector 2.0.16.1 DOM Inspector 2.0.16.1 available on the Mozilla Add-Ons page is not compatible with SeaMonkey 2.49.3. You need to use version 2.0.17.0 or higher. You can install it from DOM Inspector 2.0.17.1. This version is compatible with SeaMonkey 2.1 to 2.53 and Thunderbird 4.0 to 56.0.
Link for 2.0.17.1 is https://archive.mozilla.org/pub/seamonkey/releases/2.49.1/distributed/[e-mail]

Comment 10

[Tony Mechelynck [:tonymec]]

P.S. Bugs in DOM Inspector belong in product "Other Applications", component "DOM Inspector".

Comment 11

[Tony Mechelynck [:tonymec]]

(In reply to Ian Neal from comment #9)
> (In reply to Jonathan Kamens from comment #7)
> > I know this isn't completely on-topic for this bug, but given that it
> > relates to installing and using DOM Inspector with SeaMonkey, and I'm having
> > a problem with that, I'm hoping somebody can help me...
> > 
> > I have a version of DOM Inspector labeled "2.0.17pre" installed in SeaMonkey.
> > 
> > I don't know where I got it from, and I can't find it anywhere. I don't, for
> > example, see a development channel for DOM Inspector for AMO.
> > 
> > I found a bug in DOM Inspector with SeaMonkey that I would like to report,
> > but before reporting it I would like to check if it's still a bug in the
> > current version. But the latest version I can find online is the 2.0.16
> > signed version on AMO.
> > 
> > Is there somewhere else I should be looking to find the current development
> > release of DOM Inspector, whether that's "2.0.17pre" or something newer than
> > that?
> 
> As per release notes:
> DOM Inspector 2.0.16.1 DOM Inspector 2.0.16.1 available on the Mozilla
> Add-Ons page is not compatible with SeaMonkey 2.49.3. You need to use
> version 2.0.17.0 or higher. You can install it from DOM Inspector 2.0.17.1.
> This version is compatible with SeaMonkey 2.1 to 2.53 and Thunderbird 4.0 to
> 56.0.
> Link for 2.0.17.1 is
> https://archive.mozilla.org/pub/seamonkey/releases/2.49.1/distributed/
> [e-mail]

IIRC it should be https://archive.mozilla.org/pub/seamonkey/releases/2.49.1/distribution/extensions/[e-mail]

Comment 12

[Tony Mechelynck [:tonymec]]

ah, no, my link gives 404 Not found, I should have checked

Comment 13

[Frank-Rainer Grahl (:frg)]

Not sure if this bug shouldn't be closed. 
Basically we don't distribute DOMi any longer as of bug 1405407. This was only a temporary measure but with the apis needed for it to work now mostly ripped out of Gecko the decision to retire it is needed later for 2.57. But we first need to fix up the devtools in SeaMonkey to allow chrome inspection.

Latest DOMi in the source is 2.17.2 never released and compatible till 2.55.

Comment 14

[Frank-Rainer Grahl (:frg)]

We decided to retire DOMi with 2.57

Comment 16

[Ian Neal]

Attachment: 1273222-domi-removal-comm-257.patch

Remove DOM Inspector from build/help code

Comment 17

[Ian Neal]

Attachment: 1273222-domi-removal-moz-257.patch

Remove SM's toolkit l10n fix for DOM Inspector

Comment 18

[Ian Neal]

Attachment: 1273222-domi-removal-icons-cc.patch

Remove the icons in SM branding / installer.

Comment 19

[Ian Neal]

Attachment: 1273222-domi-removal-comm-v1_2-257.patch

Updated to include extra removals

Comment 20

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9194786 [details] [diff] [review]
1273222-domi-removal-moz-257.patch

lgtm. r/a+ for our 2.57 release branch only.

Comment 21

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9194787 [details] [diff] [review]
1273222-domi-removal-icons-cc.patch

lgtm ra+ for comm-central and 2.57

Comment 22

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9194813 [details] [diff] [review]
1273222-domi-removal-comm-v1_2-257.patch

lgtm ra+ for comm-central and 2.57

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4d354d1ae005
Stop building and deploying the DOM Inspector extension with SeaMonkey 2.57 - comm part. r=frg

Comment 24

[Frank-Rainer Grahl (:frg)]

Both patches for comm-central merged into one for rebase and checkin