1273384 - [TV][Home] The input field of edit folder name doesn't follow building blocks spec

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)

Description

[Mike Lien[:mlien]]

[Testing Steps]
1. Invoke add folder
2. Navigate to folder name's input field
3. Press OK key
4. Typing any characters

[Expected result]
Input field's status should follow building blocks spec

[Actual result]
Input field's status doesn't follow building blocks spec

[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/9a3ed0cb72e84628ca6c2c3e5b9fc4f419059268
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/ccf59a9dda868db58b5d943e2c4235ead89f9344

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1273384-card-picker-name-input-not-follow-building-block > mozilla-b2g:v2.6

Comment 2

[Fischer [:Fischer]]

Comment on attachment 8754700 [details] [review]
[gaia] Fischer-L:bug_1273384-card-picker-name-input-not-follow-building-block > mozilla-b2g:v2.6

@Luke,
This patch:
- Follow the building block to add one card-picker-input-clean-btn button to clean the input value when pressing.
- The card-picker-input-clean-btn button would show when keyboard is opened
- Just like the input, moving down from the card-picker-input-clean-btn button would focus to the last focused card.
Please have a look, thanks.

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8754700 [details] [review]
[gaia] Fischer-L:bug_1273384-card-picker-name-input-not-follow-building-block > mozilla-b2g:v2.6

Good job!

Comment 4

[Fischer [:Fischer]]

Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/035c32fb5d67edb4a8d9f8c00c910a4a56772c63

Comment 5

[Mike Lien[:mlien]]

verified and fixed with the latest build
v2.6 simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/53f70ab0313250225210e966c7407ec828265895
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/5601daf5bc520c9e6aaac667e446b1aaae3df94b