1273416 - [TV][Home] Press down arrow key while focusing on Done button in card selecion page will move focus to previous card

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)

Description

[Mike Lien[:mlien]]

[Description]
According to the latest UX spec(https://drive.google.com/open?id=0BwbmH5cX2W6Od0EwMXpSWlFwcDQ) page 13, if user presses down arrow key while focusing on Done button, it shouldn't have any action

[Testing Steps]
1. Invoke add folder
2. Select any card to let Done button be shown
3. Navigate to down button
4. Press down arrow key

[Expected result]
No action and still focus on Done button

[Actual result]
It will move focus to previous card

[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/9a3ed0cb72e84628ca6c2c3e5b9fc4f419059268
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/ccf59a9dda868db58b5d943e2c4235ead89f9344

Comment 1

[Evelyn Hung]

Hey, Luke, is something wrong in spatial navigator?

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1273416_tv_improve_card_picker_sn_rules > mozilla-b2g:v2.6

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8753715 [details] [review]
[gaia] luke-chang:1273416_tv_improve_card_picker_sn_rules > mozilla-b2g:v2.6

The way you remember the button for input is not pretty good for me :-/
but acceptable for now. If we are going to add other buttons at top we need to find another way for this.

Comment 4

[Luke Chang [:lchang] (inactive)]

Agree with you. I'll improve that if any new elements are added there. Thanks a lot!


landed on v2.6: https://github.com/mozilla-b2g/gaia/commit/54184f99d22789b67413071b28405166ad0fa68b

Comment 6

[Mike Lien[:mlien]]

verified and fixed with the latest build
v2.6 simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/53f70ab0313250225210e966c7407ec828265895
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/5601daf5bc520c9e6aaac667e446b1aaae3df94b