1273686 - Reconsider argument validation in core ping

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

In the extreme case, some values we store can overflow (e.g. sequence number), become -1 and put the device into a crash loop.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Might as well not crash loop and if we see issues on the server, we can fix things then.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1273686 - Don't crash on invalid sequence number argument in core ping. r=ahunt

Review commit: https://reviewboard.mozilla.org/r/53382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53382/

Comment 3

[Andrzej Hunt :ahunt]

Comment on attachment 8753594 [details]
MozReview Request: Bug 1273686 - Don't crash on invalid sequence number argument in core ping. r=ahunt

https://reviewboard.mozilla.org/r/53382/#review50410

::: mobile/android/base/java/org/mozilla/gecko/telemetry/pingbuilders/TelemetryCorePingBuilder.java:42
(Diff revision 1)
>   *
>   * See https://gecko.readthedocs.org/en/latest/toolkit/components/telemetry/telemetry/core-ping.html
>   * for details on the core ping.
>   */
>  public class TelemetryCorePingBuilder extends TelemetryPingBuilder {
> +    private static final String LOGTAG = StringUtils.safeSubstring(TelemetryCorePingBuilder.class.getSimpleName(), 0, 23);

It's probably worth using AppGlobals.makeLogTag here?

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://reviewboard.mozilla.org/r/53382/#review50410

> It's probably worth using AppGlobals.makeLogTag here?

It uses `Stumbler_` as its prefix so I can't. But point noted, there should be a global way to define logtags – see bug 1242091.

Also, I'm not sure how the projects are built – gradle/intellij seems fine with me adding this code, but I'm afraid our moz.build system would divide our dependencies differently and preventing me from accessing this code.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/8d6ba080209029b58c62d7bb64787327bf6b10d3
Bug 1273686 - Don't crash on invalid sequence number argument in core ping. r=ahunt

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8d6ba0802090