1273934 - switch android builds to default to libc++

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nathan Froyd [:froydnj]]

This change is only significant for local developer builds; automation
has been building with libc++ for a week or so now.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: switch android builds to default to libc++

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bbeb3300fe28

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bbeb3300fe28

Comment 4

[Andrzej Hunt :ahunt]

This seems to have broken my local builds (on an OSX machine). 

(CC'ing sebastian who I believe had the same issue this morning.)

mozconfig:

ac_add_options --enable-application=mobile/android
ac_add_options --target=arm-linux-androideabi
export MOZ_TELEMETRY_REPORTING=1
mk_add_options MOZ_OBJDIR=./objdir-frontend AUTOCLOBBER=1
ac_add_options --with-android-ndk="/Users/andrzejhunt/opt/android-ndk-r11b"

(I had the same issue running against ndk r10e, and then upgraded to r11b since I think that's our current default)

Build error:

1:03.79 In file included from /Users/andrzejhunt/ff/fx3/mfbt/endian.h:70:0,
 1:03.79                  from /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/system_wrappers/endian.h:3,
 1:03.79                  from /Users/andrzejhunt/opt/android-ndk-r11b/sources/cxx-stl/llvm-libc++/libcxx/include/__config:110,
 1:03.79                  from /Users/andrzejhunt/opt/android-ndk-r11b/sources/cxx-stl/llvm-libc++/libcxx/include/cstddef:36,
 1:03.79                  from /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/system_wrappers/cstddef:3,
 1:03.80                  from /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/Compiler.h:46,
 1:03.80                  from /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/Attributes.h:12,
 1:03.80                  from /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/Assertions.h:16,
 1:03.80                  from /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/Compression.h:12,
 1:03.80                  from /Users/andrzejhunt/ff/fx3/mfbt/Compression.cpp:7:
 1:03.80 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:39:23: error: template declaration of 'mozilla::MOZ_STACK_CLASS mozilla::DebugOnly'
 1:03.80  class MOZ_STACK_CLASS DebugOnly
 1:03.80                        ^
 1:03.80 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:41:1: error: expected primary-expression before 'public'
 1:03.80  public:
 1:03.80  ^
 1:03.80 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:41:1: error: expected '}' before 'public'
 1:03.80 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:70:3: error: 'MOZ_IMPLICIT' does not name a type
 1:03.80    MOZ_IMPLICIT DebugOnly(const T&) { }
 1:03.80    ^
 1:03.80 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:71:19: error: 'DebugOnly' does not name a type
 1:03.80    DebugOnly(const DebugOnly&) { }
 1:03.81                    ^
 1:03.81 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:72:3: error: 'DebugOnly' does not name a type
 1:03.81    DebugOnly& operator=(const T&) { return *this; }
 1:03.81    ^
 1:03.81 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:73:22: error: 'void mozilla::operator++(int)' must have an argument of class or enumerated type
 1:04.00    void operator++(int) { }
 1:04.00                       ^
 1:04.00 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:74:22: error: 'void mozilla::operator--(int)' must have an argument of class or enumerated type
 1:04.00    void operator--(int) { }
 1:04.00                       ^
 1:04.02 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:75:3: error: 'DebugOnly' does not name a type
 1:04.02    DebugOnly& operator+=(const T&) { return *this; }
 1:04.03    ^
 1:04.03 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:76:3: error: 'DebugOnly' does not name a type
 1:04.03    DebugOnly& operator-=(const T&) { return *this; }
 1:04.03    ^
 1:04.03 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:77:3: error: 'DebugOnly' does not name a type
 1:04.03    DebugOnly& operator&=(const T&) { return *this; }
 1:04.03    ^
 1:04.03 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:78:3: error: 'DebugOnly' does not name a type
 1:04.03    DebugOnly& operator|=(const T&) { return *this; }
 1:04.03    ^
 1:04.03 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:79:3: error: 'DebugOnly' does not name a type
 1:04.03    DebugOnly& operator^=(const T&) { return *this; }
 1:04.03    ^
 1:04.04 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:87:13: error: expected class-name before '(' token
 1:04.04    ~DebugOnly() {}
 1:04.04              ^
 1:04.04 /Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/mozilla/DebugOnly.h:90:1: error: expected declaration before '}' token
 1:04.04  } // namespace mozilla
 1:04.04  ^
 1:04.04 
 1:04.04 In the directory  /Users/andrzejhunt/ff/fx3/objdir-frontend/mfbt
 1:04.04 The following command failed to execute properly:
 1:04.04 /Users/andrzejhunt/opt/android-ndk-r11b/toolchains/arm-linux-androideabi-4.9/prebuilt/darwin-x86_64/bin/arm-linux-androideabi-g++ -std=gnu++11 -o Compression.o -c -I/Users/andrzejhunt/ff/fx3/objdir-frontend/dist/system_wrappers -include /Users/andrzejhunt/ff/fx3/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -I/Users/andrzejhunt/ff/fx3/mfbt -I/Users/andrzejhunt/ff/fx3/objdir-frontend/mfbt -I/Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include -I/Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/nspr -I/Users/andrzejhunt/ff/fx3/objdir-frontend/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /Users/andrzejhunt/ff/fx3/objdir-frontend/mozilla-config.h -MD -MP -MF .deps/Compression.o.pp -idirafter /Users/andrzejhunt/opt/android-ndk-r11b/platforms/android-9/arch-arm/usr/include -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wthread-safety -Wno-invalid-offsetof -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -mandroid -fno-short-enums -fno-exceptions -march=armv7-a -mthumb -mfpu=vfp -mfloat-abi=softfp -mno-unaligned-access -I/Users/andrzejhunt/opt/android-ndk-r11b/sources/android/support/include -I/Users/andrzejhunt/opt/android-ndk-r11b/sources/cxx-stl/llvm-libc++/libcxx/include -I/Users/andrzejhunt/opt/android-ndk-r11b/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pipe -g -freorder-blocks -fno-reorder-functions -Os -fomit-frame-pointer -Wno-error=shadow -Wno-unused-function /Users/andrzejhunt/ff/fx3/mfbt/Compression.cpp
 1:04.04 make[5]: *** [Compression.o] Error 1
 1:04.04 make[4]: *** [mfbt/target] Error 2