1273961 - Improve localization comments for Menu strings

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Plewako [:stef]]

The comment for the "Send" string or the string itself seems wrong (or at least it is not helpful).

https://github.com/mozilla/firefox-ios/commit/ebde8f60379c3bd338c3e0153d7f7d6ef7df8073#diff-bde1fd2235a7fb4ce3ef3a0608f177dfR227

Comment 1

[Francesco Lodolo [:flod]]

How would you change the comment? Asking because it seems clear to me: it's a "Send" button on the menu, used to share the current URL.

Comment 2

[Stefan Plewako [:stef]]

> NSLocalizedString("Menu.SendPageAction.Title", value: "Send", tableName: "Menu", comment: "String describing the action of invoking the share menu. On the menu")

I have no idea how it could be clear that this is a button label on the menu. If it would, then why it is not defined like:

> NSLocalizedString("Menu.SendPage.button.label", value: "Send", tableName: "Menu", comment: "Invoking the share menu button label (in the menu)")

Comment 3

[Francesco Lodolo [:flod]]

OK. Current comment: "String describing the action of invoking the share menu. On the menu".

What about (at this point also for the other strings): "Used as a label for the button, displayed in the menu, invoking the share dialog"?

Comment 4

[Stefan Plewako [:stef]]

(In reply to Francesco Lodolo [:flod] from comment #3)
> What about (at this point also for the other strings): "Used as a label for
> the button, displayed in the menu, invoking the share dialog"?

Great one. (if accurate)

Comment 5

[Francesco Lodolo [:flod]]

Comments updated as part of 
https://github.com/mozilla/firefox-ios/commit/99ea79a58b307a641a2cde0d94cf6d226ce8212f