[e10s] Remove release=0% in the e10s rollout add-on for 47

RESOLVED FIXED

Status

()

Firefox
General
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

47 Branch
Points:
---

Firefox Tracking Flags

(e10s+, firefox47 fixed, firefox48 unaffected, firefox49 unaffected)

Details

(Whiteboard: [fce-active])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
There are two ways to not activate any user on e10s through the system add-on settings:

1) setting the sample of users to 0% for the desired channel
2) do not specify any sampling for the desired channel


Currently, the code in beta does option 1, which is ok. However, option 2 is better both for data collection, and because it will run less code and avoid setting any prefs on the user's profile.

With that in mind, I'd prefer to have option 2 roll out with 47.
(Assignee)

Comment 1

a year ago
Created attachment 8754128 [details]
MozReview Request: Bug 1274088 - [e10s] Remove release=0% in the e10s rollout add-on for 47. r=mconley

Review commit: https://reviewboard.mozilla.org/r/53758/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53758/
Attachment #8754128 - Flags: review?(mconley)
tracking-e10s: --- → ?

Updated

a year ago
tracking-e10s: ? → +
Priority: -- → P1
Comment on attachment 8754128 [details]
MozReview Request: Bug 1274088 - [e10s] Remove release=0% in the e10s rollout add-on for 47. r=mconley

https://reviewboard.mozilla.org/r/53758/#review50688
Attachment #8754128 - Flags: review?(mconley) → review+
(Assignee)

Comment 3

a year ago
Comment on attachment 8754128 [details]
MozReview Request: Bug 1274088 - [e10s] Remove release=0% in the e10s rollout add-on for 47. r=mconley

Approval Request Comment
[Feature/regressing bug #]: e10s rollout system add-on
[User impact if declined]: this change makes it so that the add-on will run less code on release 47, where e10s will not be activated yet. It avoids some of the pref setting and sample calculations that would happen if sample = 0%. 
[Describe test coverage new/current, TreeHerder]: this patch is meant only for beta, because this change was already included in aurora through bug 1268921.
[Risks and why]: small, it reduces the risk of the add-on on release.
[String/UUID change made/needed]: none
Attachment #8754128 - Flags: approval-mozilla-beta?
Whiteboard: [fce-active]
(In reply to :Felipe Gomes (needinfo me!) from comment #0)
> There are two ways to not activate any user on e10s through the system
> add-on settings:
> 
> 1) setting the sample of users to 0% for the desired channel
> 2) do not specify any sampling for the desired channel
> 
> 
> Currently, the code in beta does option 1, which is ok. However, option 2 is
> better both for data collection, and because it will run less code and avoid
> setting any prefs on the user's profile.
> 
> With that in mind, I'd prefer to have option 2 roll out with 47.

Hey Felipe, this seems like a reasonable idea. Two questions:

1. Will this e10s system add-on be installed by default on 47 end-users that are on release channel? In other words, if I am a 47 release channel user and I go to about:support, will I see under "Extensions" something called "Multi-process staged rollout"?
2. You can also control roll out of a system add-on version by configuring a Balrog update rule for release channel. Right? So, in a way this is related to question 1. Will there be a balrog rule that has system add-ons Hello, Pocket listed for 47.0 release but not e10s system add-on.
Flags: needinfo?(felipc)

Updated

a year ago
status-firefox47: --- → affected
Comment on attachment 8754128 [details]
MozReview Request: Bug 1274088 - [e10s] Remove release=0% in the e10s rollout add-on for 47. r=mconley

e10s Beta47 experiment will run for the entire 47 cycle (an exception to the normal release process). This patch is to safeguard and ensure that e10s remains off by default on 47 release users. Beta47+
Attachment #8754128 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(Assignee)

Comment 6

a year ago
(In reply to Ritu Kothari (:ritu) from comment #4)
> (In reply to :Felipe Gomes (needinfo me!) from comment #0)
> > There are two ways to not activate any user on e10s through the system
> > add-on settings:
> > 
> > 1) setting the sample of users to 0% for the desired channel
> > 2) do not specify any sampling for the desired channel
> > 
> > 
> > Currently, the code in beta does option 1, which is ok. However, option 2 is
> > better both for data collection, and because it will run less code and avoid
> > setting any prefs on the user's profile.
> > 
> > With that in mind, I'd prefer to have option 2 roll out with 47.
> 
> Hey Felipe, this seems like a reasonable idea. Two questions:
> 
> 1. Will this e10s system add-on be installed by default on 47 end-users that
> are on release channel? In other words, if I am a 47 release channel user
> and I go to about:support, will I see under "Extensions" something called
> "Multi-process staged rollout"?

Yeah.

> 2. You can also control roll out of a system add-on version by configuring a
> Balrog update rule for release channel. Right? So, in a way this is related
> to question 1. Will there be a balrog rule that has system add-ons Hello,
> Pocket listed for 47.0 release but not e10s system add-on.

It will be part of the standard set of system add-ons that shipped with 47. If any other system add-on needs an update through Balrog during 47 release, the e10s add-on will have to be included in the ruleset, as has been discussed in the GoFaster mailing list.
If no Balrog updates are necessary for Pocket/Hello during 47 release then the e10s add-on won't create any extra work by itself.
Flags: needinfo?(felipc)
(Assignee)

Comment 7

a year ago
https://hg.mozilla.org/releases/mozilla-beta/rev/2e8129bd6590
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox47: affected → fixed
status-firefox48: --- → unaffected
status-firefox49: --- → unaffected
Resolution: --- → FIXED
Version: 46 Branch → 47 Branch
You need to log in before you can comment on or make changes to this bug.