Closed Bug 1274098 Opened 8 years ago Closed 5 years ago

Use unprefixed Fullscreen API in video document

Categories

(Toolkit :: Video/Audio Controls, enhancement)

Product:
Toolkit
Component:
Video/Audio Controls
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

Bug 1274098 - Use unprefixed Fullscreen API in video document / widgets. r?jaws
47 bytes, text/x-phabricator-request
Details | Review 
We revert video documents to use prefixed Fullscreen API in bug 1273468 because we disabled unprefixed Fullscreen API in content for release versions by default in bug 1268749, and video documents do not have chrome permission just like normal content.

Eventually, we want to use unprefixed Fullscreen API in that document again once we can stably enable the unprefixed API in content in bug 1269276.
Has this landed?
Flags: needinfo?(xidorn+moz)
No, I don't think so. We should land it. Actually, we should try to get rid of any usage of prefixed API internally (except test explicitly testing the prefixed API).
Keep the ni? for now, and see if I can find some time to work on this.
Thank you for your response.

Wasn't sure if it was duplicated somewhere else.
No. Basically, it's:
* https://searchfox.org/mozilla-central/rev/bcc0fe1081dc4f84fc5fdfebe0d2de8c075a4e2c/toolkit/content/TopLevelVideoDocument.js#56-60
* https://searchfox.org/mozilla-central/rev/bcc0fe1081dc4f84fc5fdfebe0d2de8c075a4e2c/toolkit/content/widgets/videocontrols.js#1306-1310
* https://searchfox.org/mozilla-central/rev/bcc0fe1081dc4f84fc5fdfebe0d2de8c075a4e2c/toolkit/content/widgets/videocontrols.xml#1287-1291

It's interesting that the code in videocontrols.js and videocontrols.xml seem to be duplicate. It seems the one in .js is newly migrated in bug 1431255. Tim, is there any reason we still need to keep the code around in videocontrols.xml?
Flags: needinfo?(timdream)
We will need videocontrols.xml until bug 1507895. If UA Widgets ships in 65 without incidents that will happen in 66.
Flags: needinfo?(timdream)
OK, thanks! Let's make it depend on that one so that there can be one fewer place to update :)
Depends on: 1507895
Assignee: nobody → xidorn+moz
Flags: needinfo?(xidorn+moz)
Type: defect → enhancement
Pushed by mozilla@upsuper.org:
https://hg.mozilla.org/integration/autoland/rev/cda5a7a2655c
Use unprefixed Fullscreen API in video document / widgets. r=jaws

https://hg.mozilla.org/mozilla-central/rev/cda5a7a2655c

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: