1507895 - Remove UA Widget pref and all disabled in-content bindings

Status: RESOLVED FIXED

(Core :: XBL, task, P3)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Once UA Widgets reach release, we should prevent the user from going back to the old XBL bindings by removing the pref. With that all in-content XBL bindings can be removed from the tree -- we will no longer have to maintain them.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Per offline discussion w/ :bgrins, items that can be removed should have their bugs filed separately, blocks bug 1443836, and depend on this bug.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

To be landed in Nightly 67.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1507895 - Part I, Remove the videocontrols binding

This patch removes the XBL videocontrols binding and make <video>
to always use the UA Widget to generate controls.

DevTools tests that look for NAC is switched to use <input type=file>.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1507895 - Part II, Remove the datetimebox binding

This patch removes the datetimebox binding and always use
UA Widget for the job.

Depends on D17571

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1507895 - Part III, Remove the marquee binding

This patch removes the XBL marquee binding and always uses
UA Widget for the internal "gut" of the marquee element.

Depends on D17572

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1507895 - Part IV, Remove the XBL pluginProblem binding

This patch removes the XBL pluginProblem binding and have the in-content
UI always created by the UA Widget.

Depends on D17573

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1507895 - Part V, Remove dom.ua_widget.enabled pref

With all the dependency removed this pref can be safely removed.

Depends on D17574

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1507895 - Part VI, Reword the content process XBL binding assertion

This patch cleans up the assertion added in bug 1426492.
With that we have disallowed all bindings in content HTML.

The XMLPrettyPrint binding was removed in bug 1503019.

Depends on D17575

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=68264fb913533cb6696e4d8d3af786bbedc694a4

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c2a9b446836
Part I, Remove the videocontrols binding r=smaug
https://hg.mozilla.org/integration/autoland/rev/de0a1a2cdc12
Part II, Remove the datetimebox binding r=smaug
https://hg.mozilla.org/integration/autoland/rev/951448bcc1fc
Part III, Remove the marquee binding r=smaug
https://hg.mozilla.org/integration/autoland/rev/86c320724c81
Part IV, Remove the XBL pluginProblem binding r=smaug
https://hg.mozilla.org/integration/autoland/rev/d7e0e993611f
Part V, Remove dom.ua_widget.enabled pref r=smaug
https://hg.mozilla.org/integration/autoland/rev/bcf07920d63f
Part VI, Reword the content process XBL binding assertion r=smaug

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1507895 - Fix formatting error in Part III

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/033f90fc9559
Fix formatting error in Part III

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9c2a9b446836
https://hg.mozilla.org/mozilla-central/rev/de0a1a2cdc12
https://hg.mozilla.org/mozilla-central/rev/951448bcc1fc
https://hg.mozilla.org/mozilla-central/rev/86c320724c81
https://hg.mozilla.org/mozilla-central/rev/d7e0e993611f
https://hg.mozilla.org/mozilla-central/rev/bcf07920d63f
https://hg.mozilla.org/mozilla-central/rev/033f90fc9559