Closed Bug 1274274 Opened 4 years ago Closed 4 years ago

Decouple element retrieval methods from ElementManager

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: ato, Assigned: ato)

References

(Blocks 1 open bug)

Details

(Keywords: pi-marionette-server)

Attachments

(10 files, 1 obsolete file)

58 bytes, text/x-review-board-request
automatedtester
: review+
Details
58 bytes, text/x-review-board-request
automatedtester
: review+
Details
58 bytes, text/x-review-board-request
automatedtester
: review+
Details
58 bytes, text/x-review-board-request
automatedtester
: review+
Details
58 bytes, text/x-review-board-request
automatedtester
: review+
Details
58 bytes, text/x-review-board-request
automatedtester
: review+
Details
58 bytes, text/x-review-board-request
automatedtester
: review+
Details
58 bytes, text/x-review-board-request
automatedtester
: review+
Details
58 bytes, text/x-review-board-request
automatedtester
: review+
Details
58 bytes, text/x-review-board-request
automatedtester
: review+
Details
The element retrieval methods should be decoupled from the element.ElementManager class.
Blocks: 1274251
Assignee: nobody → ato
Status: NEW → ASSIGNED
Moves element retrieval methods from ElementManager to the
testing/marionette/element.js module itself.  This means some more
work needs to be done by the caller, but avoids bloat by ensuring
ElementManager does not end up as a super-object.

Review commit: https://reviewboard.mozilla.org/r/54282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54282/
Attachment #8754888 - Flags: review?(dburns)
Attachment #8754889 - Flags: review?(dburns)
Attachment #8754890 - Flags: review?(dburns)
Attachment #8754891 - Flags: review?(dburns)
Attachment #8754892 - Flags: review?(dburns)
Attachment #8754893 - Flags: review?(dburns)
Attachment #8754894 - Flags: review?(dburns)
Attachment #8754895 - Flags: review?(dburns)
Attachment #8754896 - Flags: review?(dburns)
Attachment #8754897 - Flags: review?(dburns)
Renames ElementManager to element.Store, exposing it on the
testing/marionette/element.js module.  Shortens getKnownElement(uuid)
to get(uuid).  Introduces new method has(uuid) to replace some unnecessary
checks in testing/marionette/driver.js and testing/marionette/listener.js.

Review commit: https://reviewboard.mozilla.org/r/54286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54286/
Moved ElementManager#convertWrappedArguments to the
testing/marionette/element.js module scope and renamed it to fromJson.

Review commit: https://reviewboard.mozilla.org/r/54292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54292/
Moves ElementManager#wrapValue to the testing/marionette/element.js
module level and renames it to toJson.

Review commit: https://reviewboard.mozilla.org/r/54294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54294/
Renames instances of `elementManager' to `seenEls' for brevity.  Also the
word "manager" does not really explain what purpose it fulfills.

Review commit: https://reviewboard.mozilla.org/r/54296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54296/
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/1-2/
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/1-2/
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/1-2/
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/1-2/
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/1-2/
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/1-2/
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/1-2/
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/1-2/
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/1-2/
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/1-2/
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/2-3/
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/2-3/
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/2-3/
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/2-3/
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/2-3/
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/2-3/
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/2-3/
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/2-3/
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/2-3/
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/2-3/
Addressed a problem where the arbitrary JSON objects to marshal were not returned.  This caused a lot of tests to break.
Blocks: 1274550
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester

https://reviewboard.mozilla.org/r/54282/#review51222

::: testing/marionette/driver.js:1680
(Diff revision 3)
>    };
>  
>    switch (this.context) {
>      case Context.CHROME:
> +      if (!SUPPORTED_STRATEGIES.has(strategy)) {
> +        throw new InvalidSelectorError("Strategy not supported: " + strategy);

Let's use templating here

::: testing/marionette/driver.js:1723
(Diff revision 3)
>    };
>  
>    switch (this.context) {
>      case Context.CHROME:
> +      if (!SUPPORTED_STRATEGIES.has(strategy)) {
> +        throw new InvalidSelectorError("Strategy not supported: " + strategy);

Lets use templating here

::: testing/marionette/element.js:607
(Diff revision 3)
>  
> -      case element.Strategy.ClassName:
> +    case element.Strategy.ClassName:
> -        return startNode.getElementsByClassName(value);
> +      return startNode.getElementsByClassName(value);
>  
> -      case element.Strategy.TagName:
> +    case element.Strategy.TagName:
> +      logger.info("startNode=" + startNode);

debugging statement?
Attachment #8754888 - Flags: review?(dburns) → review+
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester

https://reviewboard.mozilla.org/r/54284/#review51226
Attachment #8754889 - Flags: review?(dburns) → review+
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester

https://reviewboard.mozilla.org/r/54286/#review51228

::: testing/marionette/element.js:162
(Diff revision 3)
> +   *     the DOM provided in the container.
> +   */
> +  get(uuid, container) {
> +    let el = this.els[uuid];
>      if (!el) {
> -      throw new JavaScriptError(`Element has not been seen before. Id given was ${id}`);
> +      throw new JavaScriptError("Element reference not seen before: " + uuid);

string template here
Attachment #8754890 - Flags: review?(dburns) → review+
Attachment #8754891 - Flags: review?(dburns) → review+
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester

https://reviewboard.mozilla.org/r/54288/#review51234
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester

https://reviewboard.mozilla.org/r/54290/#review51236
Attachment #8754892 - Flags: review?(dburns) → review+
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester

https://reviewboard.mozilla.org/r/54292/#review51238

::: testing/marionette/element.js:699
(Diff revision 3)
> +      else if (Object.keys(obj).includes(element.Key) ||
> +          Object.keys(obj).includes(element.LegacyKey)) {
> +        let uuid = obj[element.Key] || obj[element.LegacyKey];
> +        let el = this.get(uuid, {frame: win, shadowRoot: shadowRoot});
> +        if (!el) {
> +          throw new WebDriverError("Unknown element: " + uuid);

string templating
Attachment #8754893 - Flags: review?(dburns) → review+
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester

https://reviewboard.mozilla.org/r/54294/#review51240
Attachment #8754894 - Flags: review?(dburns) → review+
Attachment #8754895 - Flags: review?(dburns) → review+
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester

https://reviewboard.mozilla.org/r/54296/#review51242
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester

https://reviewboard.mozilla.org/r/54298/#review51244
Attachment #8754896 - Flags: review?(dburns) → review+
Attachment #8754897 - Flags: review?(dburns) → review+
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester

https://reviewboard.mozilla.org/r/54300/#review51246
Comment on attachment 8755368 [details]
MozReview Request: Bug 1274274 - Remove debug statement in findElements; r?automatedtester

https://reviewboard.mozilla.org/r/54572/#review51248

This commit can be fixed in the first one so merge this to that commit
Attachment #8755368 - Flags: review?(dburns)
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/3-4/
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/3-4/
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/3-4/
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/3-4/
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/3-4/
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/3-4/
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/3-4/
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/3-4/
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/3-4/
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/3-4/
Attachment #8755368 - Attachment is obsolete: true
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/4-5/
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/4-5/
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/4-5/
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/4-5/
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/4-5/
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/4-5/
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/4-5/
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/4-5/
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/4-5/
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/4-5/
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/5-6/
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/5-6/
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/5-6/
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/5-6/
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/5-6/
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/5-6/
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/5-6/
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/5-6/
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/5-6/
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/5-6/
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/6-7/
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/6-7/
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/6-7/
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/6-7/
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/6-7/
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/6-7/
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/6-7/
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/7-8/
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/7-8/
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/7-8/
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/7-8/
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/7-8/
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/6-7/
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/6-7/
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/6-7/
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/7-8/
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/7-8/
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/8-9/
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/8-9/
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/8-9/
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/8-9/
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/8-9/
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/7-8/
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/7-8/
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/7-8/
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/8-9/
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/8-9/
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/9-10/
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/9-10/
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/9-10/
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/9-10/
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/9-10/
You need to log in before you can comment on or make changes to this bug.