1274445 - WebM will lose AV sync if you switch tabs

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Steps to reproduce:

* Navigate to boring video above
* Watch video
* Change to a more interesting tab
* Change back to boring video

Expected results:

Video/audio should stay in sync

Actual results:

Audio appears to jump back and A/V sync goes out. Setting media.suspend-bkgnd-video.enabled=false makes the problem go away.

Comment 1

[Chris Peterson [:cpeterson]]

Is this bug a dupe or regression of bug 1272422?

Comment 2

[u480271]

I thought this was fixed. Will try to reproduce.

Comment 3

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Disabling background video suspend fixes the issue media.suspend-bkgnd-video.enabled=false

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1274445: [webm] P1. Track separately audio track from video track. r?kinetik

Bug 1224973 added a new usage of the MediaDataDemuxer where we would seek only inside the video track. So we can't use a common nestegg context for demuxing both the audio and video.
So instead we now use two different nestegg context.

Review commit: https://reviewboard.mozilla.org/r/56188/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56188/

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1274445: P2. Don't unnecessarily reset the decoder context. r?kamidphish

MediaFormatReader::Reset is already resetting the context.

Review commit: https://reviewboard.mozilla.org/r/56190/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56190/

Comment 6

[Matthew Gregan [:kinetik]]

Comment on attachment 8757763 [details]
MozReview Request: Bug 1274445: [webm] P1. Track separately audio track from video track. r?kinetik

https://reviewboard.mozilla.org/r/56188/#review52818

Comment 7

[u480271]

Comment on attachment 8757764 [details]
MozReview Request: Bug 1274445: P2. Don't unnecessarily reset the decoder context. r?kamidphish

https://reviewboard.mozilla.org/r/56190/#review52822

Comment 8

[Jean-Yves Avenard [:jya]]

During reset, we seek to the earliest buffered range, but that's assume the video is always the earliest.

so the seek done in reset sometimes fail, causing audio to stop playing...

Comment 9

[Jean-Yves Avenard [:jya]]

Comment on attachment 8757763 [details]
MozReview Request: Bug 1274445: [webm] P1. Track separately audio track from video track. r?kinetik

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56188/diff/1-2/

Comment 10

[Jean-Yves Avenard [:jya]]

Comment on attachment 8757764 [details]
MozReview Request: Bug 1274445: P2. Don't unnecessarily reset the decoder context. r?kamidphish

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56190/diff/1-2/

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0149fb3567b4
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c383b2162f7

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0149fb3567b4
https://hg.mozilla.org/mozilla-central/rev/5c383b2162f7

Comment 13

[Jean-Yves Avenard [:jya]]

Attachment: Disable multi-threaded decoding when using old version of LibAV. r?kentuckyfriedtakahe

MozReview-Commit-ID: 60XDTJJqpFR