1274720 - Don't use DrawTargetCG for drawing popups (context menus, panels)

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Markus Stange [:mstange]]

Instead, draw into a Skia DrawTarget, rewrap the bits in a CGImageRef, and draw that to the window.

Comment 1

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1274720 - Don't use DrawTargetCG for drawing popups. r?jrmuizel

Review commit: https://reviewboard.mozilla.org/r/54372/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54372/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8755057 [details]
MozReview Request: Bug 1274720 - Don't use DrawTargetCG for drawing popups. r?jrmuizel

https://reviewboard.mozilla.org/r/54372/#review52554

::: widget/cocoa/nsChildView.h:688
(Diff revision 1)
>    RefPtr<mozilla::SwipeTracker> mSwipeTracker;
>    mozilla::UniquePtr<mozilla::SwipeEventQueue> mSwipeEventQueue;
>  
> +  // Only used for drawRect-based painting in popups.
> +  mozilla::UniquePtr<unsigned char[]> mBackingSurfaceData;
> +  mozilla::gfx::IntSize mBackingSurfaceSize;

Can this just be a DrawTarget instead of tracking this separately? We can just call LockRect on the DrawTarget.

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8755057 [details]
MozReview Request: Bug 1274720 - Don't use DrawTargetCG for drawing popups. r?jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54372/diff/1-2/

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8755057 [details]
MozReview Request: Bug 1274720 - Don't use DrawTargetCG for drawing popups. r?jrmuizel

https://reviewboard.mozilla.org/r/54372/#review53456

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/061b48fc0614
Don't use DrawTargetCG for drawing popups. r=jrmuizel

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/061b48fc0614

Comment 7

[Eric Rahm [:erahm]]

FWIW, this broke drawing pop-ups if you were using the cg-only backend, ie: "gfx.content.azure.backends=cg" (I had it set when testing memory usage switching over to skia, forget to reset it). I wonder if we should just get rid of that pref.