1258751 - Delete the CoreGraphics backend (remove DrawTargetCG)

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mason Chang [Inactive] [:mchang]]

+++ This bug was initially created as a clone of Bug #1186552 +++

Delete the CoreGraphics backend once skia-content reaches release on OS X.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Delete the Coregraphics Backend

I had to reorganize a few things in DrawTargetCG.h into Helpers.h as some of that was shared with other parts of the code. Otherwise, it's a straight deletion.

It also includes the promised ASCII art tombstone for DrawTargetCG we can optionally keep :).

Comment 2

[Jeff Muizelaar [:jrmuizel]]

I'd rather wait a while with this unless there's a compelling reason to delete it now. It's currently handy to be able to switch backends just for testing.

Comment 3

[Mason Chang [Inactive] [:mchang]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #2)
> I'd rather wait a while with this unless there's a compelling reason to
> delete it now. It's currently handy to be able to switch backends just for
> testing.

How long is a while? I wasn't going to land this until Gecko 51 also.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Right we talked about the timing - 48 is when we first ship Skia content, which means 51 is as early as we could do it.  No harm in waiting a release or two longer.  If we wait until 53, we will have one more ESR (52) with the ability to switch.

On the other hand, we have already broken CG backend in nightly, from what I can tell (no popups?)

Comment 5

[Mason Chang [Inactive] [:mchang]]

From our conversation today, we'll delete this in 53.

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8766462 [details] [diff] [review]
Delete the Coregraphics Backend

Review of attachment 8766462 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/DrawTargetCG.h
@@ +13,5 @@
> +    *                                                                                                                                         *
> +    *                                                                                                                                         *
> +    *                                                                                                                                         *
> +    *                                                       ____    ____  ____                                                                *
> +    *                                                       |  _ \  |_ _| |  _ \                                                              *

Yeah, now that we've all had one good look at this tombstone, let's stop there and not actually include it in the code. :-)

::: gfx/2d/ScaledFontMac.cpp
@@ +86,5 @@
>    return ScaledFontBase::GetPathForGlyphs(aBuffer, aTarget);
>  }
>  
>  void
>  ScaledFontMac::CopyGlyphsToBuilder(const GlyphBuffer &aBuffer, PathBuilder *aBuilder, BackendType aBackendType, const Matrix *aTransformHint)

Let's remove the override completely.

::: widget/uikit/nsWindow.mm
@@ -364,5 @@
> -    dt->AddUserData(&gfxContext::sDontUseAsSourceKey, dt, nullptr);
> -    targetContext = gfxContext::CreateOrNull(dt);
> -  } else if (gfxPlatform::GetPlatform()->SupportsAzureContentForType(gfx::BackendType::CAIRO)) {
> -    // This is dead code unless you mess with prefs, but keep it around for
> -    // debugging.

Please don't remove this comment.

Comment 7

[Mason Chang [Inactive] [:mchang]]

Try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3935fbcd268

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0eeb7cf36fc
Delete the CoreGraphics backend. r=mstange

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a0eeb7cf36fc

Comment 10

[u459114]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2da969fcf8424a525f9048eaf7da336db45c3e86
Bug 1258751 - followup: remove out-of-date comment. r=me DONTBUILD

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2da969fcf842

Comment 12

[Markus Stange [:mstange]]

PathCG is still alive. Should it go away, too?