127479 - Drag n drop add to bookmark when no other bookmarks present is broken

Status: RESOLVED WORKSFORME

(SeaMonkey :: Bookmarks & History, defect)

Description

[Scott]

Removed every single bookmark, including separators, etc.  Adding new bookmarks
by drag and drop, either into the sidepane or into the Bookmark Manage dialog,
then silently fails.  Adding a bookmark by using the Add Bookmark button and
dialog does work.  This has been broken since at least the Dec 11, 2001 build.

Comment 1

[Chris Lyon]

Scott, what build are you using?

Also, are there any errors in the JavaScript console?

Comment 2

[Scott]

This is build 2002022307.  No errors appear in the Javascript console.  There is
no feedback at all when I drag a URL into the Bookmarks pane.  This is strange
because when other bookmarks are present, a thin short bar will appear between
them to indicate where the new bookmark will be placed.  No such bar appears
when the list is empty.

Comment 3

[Chris Lyon]

Scott, are you still seeing this on a recent build?

Comment 4

[Scott]

Yes.  The 20020314 build mozilla.org still does this.

Comment 5

[Sitsofe Wheeler]

With Moz 1.0 Windows:

I would not say that it fails silently - I get a "can't drop here" symbol 
when I drag the bookmark to the sidebar pane/bookmark manager attempt to do this. If I drag to the 
title bar of the bookmark side bar then I the cursor changes but lettting go does nothing. 

It 
does seem a bit strange that a new bookmark isn't made so I'm confirming. Since this bug can be 
worked around I am reducing the severity to minor.

Comment 6

[Paul Wyskoczka]

nsbeta1+/adt2 per the nav triage team.

Comment 7

[José Jeria]

*** Bug 182660 has been marked as a duplicate of this bug. ***

Comment 8

[José Jeria]

*** Bug 182660 has been marked as a duplicate of this bug. ***

Comment 9

[Jan Varga [:janv]]

reassigning

Comment 10

[Samir Gehani]

Nav triage team: nsbeta1+/adt3

Comment 11

[Martin Roell]

The bug is still present in Mozilla 1.4 (20030624).

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

*** Bug 211926 has been marked as a duplicate of this bug. ***

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

WFM with:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113
Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.5) Gecko/20031107 Debian/1.5-3

Can anyone still see this bug? If not we could mark it as WORKSFORME.

Comment 14

[Scott]

It's still a problem with Moz 1.5.  I haven't upgraded to 1.6 or later, so I
can't confirm there.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Scott, you always tried a fresh profile? If not please do it. Also try a current
build. We can't leave this bug open because SM 1.5 always show this bug. There
is no further development on this branch.

Comment 16

[Scott]

Tried with:

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7a) Gecko/20040214

Problem persists.  Creating a new profile makes no difference.

Comment 17

[sander benders]

also in Mozilla 1.7rc2

Comment 18

[OstGote!]

Still in 1.8a. See bug 245474 comment 1.

Comment 19

[Wayne Mery (:wsmwk)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050702

I seem to remember a similar firefox bug fixed in the past year or two (but I'm
not going to go looking for it). 

Create the conditions under another scenario - with an empty folder (don't need
empty bookmark file).

steps to reproduce
1. ctrl-b manage bookmarks
2. create an empty folder
3. right click empty folder and open in new window
4. position bookmark windows so it won't be blocked by browser window after drop
5. drag bookmark from address field to window with empty bookmar folder
result:
invalid operation icon

However, D&D works if ANYTHING is in the folder, for example a seperator or
another folder.

Possibly related (possibly not) in that new folder, all functions related to
adding content to the folder are greyed out.


(cleared target milestone which has past)

Comment 20

[Wayne Mery (:wsmwk)]

(In reply to comment #19)
> Possibly related (possibly not) in that new folder, all functions related to
> adding content to the folder are greyed out.

... as described in bug 301983

Comment 21

[Erik Staats]

The code that handles the drop logic for this case is in mozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp nsTreeBodyFrame::HandleEvent.  If the drag coordinates are in the tree body frame but not in a row, the drag session canDrop attribute is set to false, preventing the drop action.

If nsTreeBodyFrame::ComputeDropPosition is changed to select dropAfter for the last row when the drag coordinates are in the tree body frame but not in a row, the drop action will drop after the last row.

Songbird has a similar bug for dropping items in playlist trees (bug 4592 http://bugzilla.songbirdnest.com/show_bug.cgi?id=4592).

Comment 22

[Phoenix]

Can't reproduce on current nightly, closing
User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/18.0 Firefox/18.0 SeaMonkey/2.15a1
Build identifier: 20120921003032