Closed Bug 1274835 Opened 5 years ago Closed 5 years ago
Extract functions processing basic shapes from clip-path logic
58 bytes, text/x-review-board-request
Currently, the logics dealing with basic shapes are coupled with clip-path logic in nsRuleNode and nsComputedDOMStyle. I would like to refactor them into functions so that they can be reused while implementing shape-outside.
This can be used in the implementation of shape-outside. Review commit: https://reviewboard.mozilla.org/r/54446/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54446/
Attachment #8755264 - Flags: review?(cam)
https://reviewboard.mozilla.org/r/54446/#review51110 The diff looks messy, but what I did is simplely extract the logic handling basic shape into functions.
Comment on attachment 8755264 [details] MozReview Request: Bug 1274835 - Refactor code to process basic shape from clip-path. https://reviewboard.mozilla.org/r/54446/#review51114
Attachment #8755264 - Flags: review?(cam) → review+
You need to log in before you can comment on or make changes to this bug.