Closed
Bug 1274835
Opened 8 years ago
Closed 8 years ago
Extract functions processing basic shapes from clip-path logic
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Currently, the logics dealing with basic shapes are coupled with clip-path logic in nsRuleNode and nsComputedDOMStyle. I would like to refactor them into functions so that they can be reused while implementing shape-outside.
|
Assignee | |
Comment 1•8 years ago
|
||
This can be used in the implementation of shape-outside. Review commit: https://reviewboard.mozilla.org/r/54446/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54446/
Attachment #8755264 -
Flags: review?(cam)
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://reviewboard.mozilla.org/r/54446/#review51110 The diff looks messy, but what I did is simplely extract the logic handling basic shape into functions.
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8755264 [details] MozReview Request: Bug 1274835 - Refactor code to process basic shape from clip-path. https://reviewboard.mozilla.org/r/54446/#review51114
Attachment #8755264 -
Flags: review?(cam) → review+
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9318af26432b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•