Open
Bug 1098939
(shape-outside)
Opened 10 years ago
Updated 10 months ago
[meta] Implement CSS shape-outside property
Categories
(Core :: Layout: Floats, enhancement, P2)
Core
Layout: Floats
Tracking
()
NEW
People
(Reporter: igor, Unassigned)
References
(Depends on 3 open bugs, Blocks 3 open bugs, )
Details
(6 keywords, Whiteboard: [DevRel:P1])
Attachments
(1 obsolete file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.122 Safari/537.36 Steps to reproduce: This bug tracks the overall implementation of the shape outside feature(http://dev.w3.org/csswg/css-shapes/#propdef-shape-outside)
Reporter | ||
Updated•10 years ago
|
Component: Untriaged → Layout: Floats
Product: Firefox → Core
Updated•10 years ago
|
Assignee: nobody → igor
Comment hidden (offtopic) |
Updated•10 years ago
|
Flags: needinfo?(tonikitoo)
Comment hidden (offtopic) |
Comment hidden (offtopic) |
Updated•9 years ago
|
Keywords: dev-doc-needed
Updated•9 years ago
|
Blocks: css-shapes-1
Updated•9 years ago
|
Assignee: nobody → tlin
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Updated•9 years ago
|
Assignee: tlin → nobody
Status: ASSIGNED → NEW
Updated•9 years ago
|
Updated•9 years ago
|
Whiteboard: [parity-webkit][parity-blink]
Updated•9 years ago
|
Keywords: DevAdvocacy
Updated•9 years ago
|
Whiteboard: [parity-webkit][parity-blink] → [parity-webkit][parity-blink][DevRel:P1]
Updated•9 years ago
|
Assignee: nobody → tlin
Status: NEW → ASSIGNED
Summary: [META][CSS Shapes] Implement shape-outside → Implement CSS shape-outside property
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54228/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54228/
Comment 5•8 years ago
|
||
https://reviewboard.mozilla.org/r/54228/#review51418 ::: layout/style/nsCSSPropList.h:3705 (Diff revision 1) > +CSS_PROP_DISPLAY( > + shape-outside, > + shape_outside, > + ShapeOutside, > + CSS_PROPERTY_PARSE_VALUE | > + CSS_PROPERTY_VALUE_PARSER_FUNCTION, Perhaps you'll need CSS_PROPERTY_APPLIES_TO_FIRST_LETTER here to apply to floating first-letter.
Updated•8 years ago
|
Flags: platform-rel?
Updated•8 years ago
|
platform-rel: --- → ?
Updated•8 years ago
|
Attachment #8755323 -
Attachment is obsolete: true
Comment 6•8 years ago
|
||
Based on IRC discussion with Xidorn, attr() support should not block the implementation of shape-outside.
No longer depends on: 435426
Depends on: 1309830
Comment 7•8 years ago
|
||
Turn this into a meta bug.
Alias: shape-outside
Assignee: tlin → nobody
Status: ASSIGNED → NEW
Summary: Implement CSS shape-outside property → [meta] Implement CSS shape-outside property
Updated•8 years ago
|
Updated•8 years ago
|
Comment 8•8 years ago
|
||
I've added a note to https://developer.mozilla.org/en-US/Firefox/Experimental_features#CSS and https://developer.mozilla.org/en-US/docs/Web/CSS/shape-outside about the implementation status. Sebastian
Updated•8 years ago
|
platform-rel: ? → ---
Comment 9•8 years ago
|
||
As all main values of shape-outside are implemented now, I think it's time to at least enable it by default on Nightly and DevEdition. What do you think, Ting-Yu? Sebastian
Flags: needinfo?(tlin)
Comment 10•8 years ago
|
||
Re comment 9: I filed bug 1353631 to track all the bugs that needs to fixed before enabling shape-outside on Nightly and Aurora. We still need animation support for <basic-shape> (bug 1289049). > As all main values of shape-outside are implemented now Not really. We still lack "shape-outside: <image>" support, which might not block enabling on Nightly and Aurora, but it definitely blocks shipping. To implement it, we need to fix bug 1265343. In general, shape-outside more or less makes stylo harder to ship because we need to support those CSS properties in servo as well, and I'll need to do them twice (once in gecko and once in servo). Given that, I might postpone doing them until we enable stylo on Nightly so that I only need to implement them once.
Flags: needinfo?(tlin)
Comment 11•8 years ago
|
||
Yeah, WebKit&blink supported shape-outside: <image>.
Comment 12•8 years ago
|
||
(In reply to Ting-Yu Lin [:TYLin] (UTC+8) from comment #10) > Re comment 9: > > I filed bug 1353631 to track all the bugs that needs to fixed before > enabling shape-outside on Nightly and Aurora. Great, thanks! > > As all main values of shape-outside are implemented now > > Not really. We still lack "shape-outside: <image>" support, which might not > block enabling on Nightly and Aurora, but it definitely blocks shipping. To > implement it, we need to fix bug 1265343. > > In general, shape-outside more or less makes stylo harder to ship because we > need to support those CSS properties in servo as well, and I'll need to do > them twice (once in gecko and once in servo). Given that, I might postpone > doing them until we enable stylo on Nightly so that I only need to implement > them once. (In reply to percyley from comment #11) > Yeah, WebKit&blink supported shape-outside: <image>. I can't test WebKit, but as far as I can see, Blink parses "shape-outside: <image>" and shape-image-threshold but doesn't actually implement them. See http://codepen.io/team/css-tricks/pen/fbe5379f499f072e55fa1e4fbab5c8d5 or http://codepen.io/anon/pen/YZMxVP. Sebastian
Comment 13•8 years ago
|
||
@Sebastian There is a problem with the first test case, which must contain a transparent region. Please test this: http://codepen.io/AmeliaBR/pen/DgrCo and http://hansmuller-webkit.blogspot.com/2013/11/css-shapes-from-images.html The second example is the PNG image problem, use this: https://img.alicdn.com/tfs/TB1baHDQpXXXXX9XVXXXXXXXXXX-406-406.png
Comment 14•8 years ago
|
||
Ah, thank you! The second one was obviously my fault, should have been like http://codepen.io/anon/pen/qrGZgR. The second one came from https://css-tricks.com/almanac/properties/s/shape-outside/. Sebastian
Updated•7 years ago
|
Updated•7 years ago
|
Assignee: nobody → bwerth
Comment 15•7 years ago
|
||
Mass bug change to replace various 'parity' whiteboard flags with the new canonical keywords. (See bug 1443764 comment 13.)
Keywords: parity-chrome,
parity-safari
Whiteboard: [parity-webkit][parity-blink][DevRel:P1] → [DevRel:P1]
Comment 16•6 years ago
|
||
Taking myself off now that Ting-Yu has returned to implementing the feature.
Assignee: bwerth → nobody
Updated•6 years ago
|
Type: defect → enhancement
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•